Review main Merged

80627[TASK] Migrate @typo3/form/backend/form-editor/stage-component to TypeScript

Benjamin Franzke CR +2 V +2 Expert +902 −1197 updated 08/28/23, 14:50

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1619

  1. Benjamin Franzke uploaded patch set 1 08/23/23, 07:09

    Initial-Upload git mv only
  2. Benjamin Franzke uploaded patch set 2 08/23/23, 07:10

    Reindent file
  3. Benjamin Franzke uploaded patch set 3 08/23/23, 07:11

    Apply eslint fix
  4. Benjamin Franzke uploaded patch set 4 08/23/23, 07:11

    Manual eslint fixes
  5. Benjamin Franzke uploaded patch set 5 08/23/23, 07:12

    Define types
  6. core-ci voted on patch set 5 V +1 08/23/23, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45719

  7. Benjamin Franzke marked it ready for review 08/23/23, 08:44

  8. Andreas Kienast commented on patch set 5 08/24/23, 13:51

    stage-component.ts:324

    This method seems to be unused. Is this public API?

    stage-component.ts:646

    For later™: This argument is unused in any invocation.
  9. Andreas Kienast voted on patch set 5 V +1 CR +1 08/24/23, 14:08

  10. Benjamin Franzke rebased onto patch set 6 CR +1 V +1 08/24/23, 18:27

    Rebase
  11. Benjamin Franzke commented on patch set 6 08/24/23, 18:27

    stage-component.ts:324 Reply

    yes, was exposed as module export, so I kept it.

    stage-component.ts:646 Reply

    good catch, but as discussed, that can't be changed without breaking the "api".
  12. core-ci voted on patch set 6 V +1 08/24/23, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45800

  13. Benjamin Franzke rebased onto patch set 7 V +1 08/25/23, 05:03

    Rebase
  14. core-ci voted on patch set 7 V +1 08/25/23, 05:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45814

  15. Andreas Kienast voted on patch set 7 V +1 CR +1 08/25/23, 05:57

  16. Christian Kuhn voted on patch set 7 V +1 08/28/23, 08:56

  17. Benjamin Kott voted on patch set 7 V +1 CR +1 08/28/23, 13:44

  18. Benjamin Franzke voted on patch set 7 V +2 CR +2 08/28/23, 13:46

  19. Benjamin Franzke merged patch set 8 08/28/23, 14:50