80627[TASK] Migrate @typo3/form/backend/form-editor/stage-component to TypeScript
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benjamin Kott +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Christian Kuhn +1
- Andreas Kienast +1
- Benjamin Kott +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1619
-
Benjamin Franzke uploaded patch set 1 08/23/23, 07:09
Initial-Upload git mv only -
Benjamin Franzke uploaded patch set 2 08/23/23, 07:10
Reindent file -
Benjamin Franzke uploaded patch set 3 08/23/23, 07:11
Apply eslint fix -
Benjamin Franzke uploaded patch set 4 08/23/23, 07:11
Manual eslint fixes -
Benjamin Franzke uploaded patch set 5 08/23/23, 07:12
Define types -
core-ci voted on patch set 5 V +1 08/23/23, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45719
-
Benjamin Franzke marked it ready for review 08/23/23, 08:44
-
Andreas Kienast commented on patch set 5 08/24/23, 13:51
stage-component.ts:324This method seems to be unused. Is this public API?stage-component.ts:646For later™: This argument is unused in any invocation. -
Andreas Kienast voted on patch set 5 V +1 CR +1 08/24/23, 14:08
-
Benjamin Franzke rebased onto patch set 6
CR +1V +108/24/23, 18:27Rebase -
Benjamin Franzke commented on patch set 6 08/24/23, 18:27
stage-component.ts:324Replyyes, was exposed as module export, so I kept it.stage-component.ts:646Replygood catch, but as discussed, that can't be changed without breaking the "api". -
core-ci voted on patch set 6 V +1 08/24/23, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45800
-
Benjamin Franzke rebased onto patch set 7
V +108/25/23, 05:03Rebase -
core-ci voted on patch set 7 V +1 08/25/23, 05:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45814
-
Andreas Kienast voted on patch set 7 V +1 CR +1 08/25/23, 05:57
-
Christian Kuhn voted on patch set 7 V +1 08/28/23, 08:56
-
Benjamin Kott voted on patch set 7 V +1 CR +1 08/28/23, 13:44
-
Benjamin Franzke voted on patch set 7 V +2 CR +2 08/28/23, 13:46
-
Benjamin Franzke merged patch set 8 08/28/23, 14:50