80628[TASK] Migrate @typo3/form/backend/form-editor/inspector-component to TypeScript
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benjamin Kott +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Christian Kuhn +1
- Andreas Kienast +1
- Benjamin Kott +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1619
-
Benjamin Franzke uploaded patch set 1 08/23/23, 07:13
Initial-Upload git mv only -
Benjamin Franzke uploaded patch set 2 08/23/23, 07:13
Reindent file -
Benjamin Franzke uploaded patch set 3 08/23/23, 07:14
Apply eslint fix -
Benjamin Franzke uploaded patch set 4 08/23/23, 07:15
Manual eslint fixes -
Benjamin Franzke uploaded patch set 5 08/23/23, 07:17
Define types -
core-ci voted on patch set 5 V +1 08/23/23, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45724
-
Benjamin Franzke marked it ready for review 08/23/23, 08:44
-
Andreas Kienast commented on patch set 5 08/24/23, 13:11
inspector-component.ts:205Looks dead to me -
Benjamin Franzke uploaded patch set 6
V +108/24/23, 18:29Cosmetics -
Benjamin Franzke commented on patch set 6 08/24/23, 18:29
inspector-component.ts:205ReplyDone -
Benjamin Franzke commented on patch set 6 V -1 08/24/23, 18:46
Country select errors in inspector ``` inspector-component.js?bust=1692902181:13 Uncaught TypeError: Cannot convert undefined or null to object at Function.keys (<anonymous>) at renderCountrySelectEditor (inspector-component.js?bust=1692902181:13:22721) at renderEditorDispatcher (inspector-component.js?bust=1692902181:13:4876) at Module.renderEditors (inspector-component.js?bust=1692902181:13:13095) at o (view-model.js?bust=1692902181:13:15998) at HTMLDivElement.<anonymous> (view-model.js?bust=1692902181:13:16087) at opt.complete (jquery.js?bust=1692902181:7824:12) at fire (jquery.js?bust=1692902181:3538:31) at Object.fireWith [as resolveWith] (jquery.js?bust=1692902181:3668:7) at tick (jquery.js?bust=1692902181:7667:13) ``` -
core-ci voted on patch set 6 V +1 08/24/23, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45801
-
Benjamin Franzke uploaded patch set 7
V +108/25/23, 05:06Object.keys safeguard -
core-ci voted on patch set 7 V +1 08/25/23, 05:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45815
-
Andreas Kienast voted on patch set 7 V +1 CR +1 08/25/23, 05:57
-
Christian Kuhn voted on patch set 7 V +1 08/28/23, 08:56
-
Benjamin Kott voted on patch set 7 V +1 CR +1 08/28/23, 13:44
-
Benjamin Franzke voted on patch set 7 V +2 CR +2 08/28/23, 13:46
-
Benjamin Franzke merged patch set 8 08/28/23, 14:50