Review main Merged

80628[TASK] Migrate @typo3/form/backend/form-editor/inspector-component to TypeScript

Benjamin Franzke CR +2 V +2 Nightmare +2519 −2789 updated 08/28/23, 14:50

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1619

  1. Benjamin Franzke uploaded patch set 1 08/23/23, 07:13

    Initial-Upload git mv only
  2. Benjamin Franzke uploaded patch set 2 08/23/23, 07:13

    Reindent file
  3. Benjamin Franzke uploaded patch set 3 08/23/23, 07:14

    Apply eslint fix
  4. Benjamin Franzke uploaded patch set 4 08/23/23, 07:15

    Manual eslint fixes
  5. Benjamin Franzke uploaded patch set 5 08/23/23, 07:17

    Define types
  6. core-ci voted on patch set 5 V +1 08/23/23, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45724

  7. Benjamin Franzke marked it ready for review 08/23/23, 08:44

  8. Andreas Kienast commented on patch set 5 08/24/23, 13:11

    inspector-component.ts:205

    Looks dead to me
  9. Benjamin Franzke uploaded patch set 6 V +1 08/24/23, 18:29

    Cosmetics
  10. Benjamin Franzke commented on patch set 6 08/24/23, 18:29

    inspector-component.ts:205 Reply

    Done
  11. Benjamin Franzke commented on patch set 6 V -1 08/24/23, 18:46

    Country select errors in inspector ``` inspector-component.js?bust=1692902181:13 Uncaught TypeError: Cannot convert undefined or null to object at Function.keys (<anonymous>) at renderCountrySelectEditor (inspector-component.js?bust=1692902181:13:22721) at renderEditorDispatcher (inspector-component.js?bust=1692902181:13:4876) at Module.renderEditors (inspector-component.js?bust=1692902181:13:13095) at o (view-model.js?bust=1692902181:13:15998) at HTMLDivElement.<anonymous> (view-model.js?bust=1692902181:13:16087) at opt.complete (jquery.js?bust=1692902181:7824:12) at fire (jquery.js?bust=1692902181:3538:31) at Object.fireWith [as resolveWith] (jquery.js?bust=1692902181:3668:7) at tick (jquery.js?bust=1692902181:7667:13) ```
  12. core-ci voted on patch set 6 V +1 08/24/23, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45801

  13. Benjamin Franzke uploaded patch set 7 V +1 08/25/23, 05:06

    Object.keys safeguard
  14. core-ci voted on patch set 7 V +1 08/25/23, 05:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45815

  15. Andreas Kienast voted on patch set 7 V +1 CR +1 08/25/23, 05:57

  16. Christian Kuhn voted on patch set 7 V +1 08/28/23, 08:56

  17. Benjamin Kott voted on patch set 7 V +1 CR +1 08/28/23, 13:44

  18. Benjamin Franzke voted on patch set 7 V +2 CR +2 08/28/23, 13:46

  19. Benjamin Franzke merged patch set 8 08/28/23, 14:50