80629[TASK] Migrate @typo3/form/backend/form-editor/view-model to TypeScript
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benjamin Kott +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Christian Kuhn +1
- Andreas Kienast +1
- Benjamin Kott +1
- core-ci +1 CI
Issues 2
Files 6
- Build/Sources/TypeScript/form/backend/form-editor/inspector-component.ts+1 −1
- Build/Sources/TypeScript/form/backend/form-editor/stage-component.ts+1 −1
- Build/Sources/TypeScript/form/backend/form-editor/view-model.ts3new+1431 −0
- Build/Sources/TypeScript/form/backend/form-editor.ts+2 −11
- Build/Sources/TypeScript/form/backend/helper.ts+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/view-model.js+1 −1976
Review log 1721
-
Benjamin Franzke uploaded patch set 1 08/23/23, 07:17
Initial-Upload git mv only -
Benjamin Franzke uploaded patch set 2 08/23/23, 07:18
Reindent file -
Benjamin Franzke uploaded patch set 3 08/23/23, 07:18
Apply eslint fix -
Benjamin Franzke uploaded patch set 4 08/23/23, 07:19
Manual eslint fixes -
Benjamin Franzke uploaded patch set 5 08/23/23, 07:20
Define types -
core-ci voted on patch set 5 V +1 08/23/23, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45729
-
Benjamin Franzke marked it ready for review 08/23/23, 08:44
-
Andreas Kienast commented on patch set 5 08/24/23, 13:47
view-model.ts:532This method seems to be unused. Is this public API? -
Benjamin Franzke commented on patch set 5 08/24/23, 13:51
view-model.ts:532Replyyes, was exposed as module export, so I kept it. -
Andreas Kienast voted on patch set 5 V +1 CR +1 08/24/23, 14:08
-
Benjamin Franzke uploaded patch set 6
CR +1V +108/24/23, 18:33Cosmetics -
Benjamin Franzke commented on patch set 6 08/24/23, 18:33
view-model.ts:532ReplyAdded a TOOD to deprecate this one in future. -
core-ci voted on patch set 6 V +1 08/24/23, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45802
-
Benjamin Franzke uploaded patch set 7
V +108/25/23, 05:07Object.keys safeguard -
core-ci voted on patch set 7 V -1 08/25/23, 05:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45816
-
core-ci voted on patch set 7 V +1 08/25/23, 05:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45816
-
Andreas Kienast voted on patch set 7 V +1 CR +1 08/25/23, 05:55
-
Christian Kuhn voted on patch set 7 V +1 08/28/23, 08:54
-
Benjamin Kott voted on patch set 7 V +1 CR +1 08/28/23, 13:44
-
Benjamin Franzke voted on patch set 7 V +2 CR +2 08/28/23, 13:46
-
Benjamin Franzke merged patch set 8 08/28/23, 14:52