Review main Merged

80629[TASK] Migrate @typo3/form/backend/form-editor/view-model to TypeScript

Benjamin Franzke CR +2 V +2 Nightmare +1437 −1990 updated 08/28/23, 14:52

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 1721

  1. Benjamin Franzke uploaded patch set 1 08/23/23, 07:17

    Initial-Upload git mv only
  2. Benjamin Franzke uploaded patch set 2 08/23/23, 07:18

    Reindent file
  3. Benjamin Franzke uploaded patch set 3 08/23/23, 07:18

    Apply eslint fix
  4. Benjamin Franzke uploaded patch set 4 08/23/23, 07:19

    Manual eslint fixes
  5. Benjamin Franzke uploaded patch set 5 08/23/23, 07:20

    Define types
  6. core-ci voted on patch set 5 V +1 08/23/23, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45729

  7. Benjamin Franzke marked it ready for review 08/23/23, 08:44

  8. Andreas Kienast commented on patch set 5 08/24/23, 13:47

    view-model.ts:532

    This method seems to be unused. Is this public API?
  9. Benjamin Franzke commented on patch set 5 08/24/23, 13:51

    view-model.ts:532 Reply

    yes, was exposed as module export, so I kept it.
  10. Andreas Kienast voted on patch set 5 V +1 CR +1 08/24/23, 14:08

  11. Benjamin Franzke uploaded patch set 6 CR +1 V +1 08/24/23, 18:33

    Cosmetics
  12. Benjamin Franzke commented on patch set 6 08/24/23, 18:33

    view-model.ts:532 Reply

    Added a TOOD to deprecate this one in future.
  13. core-ci voted on patch set 6 V +1 08/24/23, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45802

  14. Benjamin Franzke uploaded patch set 7 V +1 08/25/23, 05:07

    Object.keys safeguard
  15. core-ci voted on patch set 7 V -1 08/25/23, 05:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45816

  16. core-ci voted on patch set 7 V +1 08/25/23, 05:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45816

  17. Andreas Kienast voted on patch set 7 V +1 CR +1 08/25/23, 05:55

  18. Christian Kuhn voted on patch set 7 V +1 08/28/23, 08:54

  19. Benjamin Kott voted on patch set 7 V +1 CR +1 08/28/23, 13:44

  20. Benjamin Franzke voted on patch set 7 V +2 CR +2 08/28/23, 13:46

  21. Benjamin Franzke merged patch set 8 08/28/23, 14:52