Review main Abandoned

80667[WIP][BUGFIX] Fix CSS in component shadowRoots when used cross frames

Benjamin Franzke CR 0 V 0 Normal +91 −10 updated 08/25/23, 09:16

Commit message

When a custom element is created within an iframe via
`document.createElement()` and is then attached to another
frame (e.g. via parent.document.body.appendChild()),
then the browser throws an exception when a CSSStyleSheet
object, created on the iframe window object is attached
to the outer documents object.

TODO:
 * consider trying to merge this fix upstream(, but:)
 * firefox has even more problems:
   Uncaught TypeError: this.createRenderRoot is not a function

Review

  • Code review CR 0
  • Verified V 0

Issues 3

Files 6

Review log 23

  1. Benjamin Franzke uploaded patch set 1 08/24/23, 12:10

  2. core-ci voted on patch set 1 V +1 08/24/23, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45784

  3. Benjamin Franzke abandoned the change 08/25/23, 09:16

    cross-frame components do not work in firefox at all, details: https://forge.typo3.org/issues/101747#note-4