Review 12.4 Merged

80691[TASK] Stateless TsConfigTreeBuilder

Christian Kuhn CR +2 V +2 Easy +12 −18 updated 08/30/23, 17:07

Commit message

We can reduce class state by explicitely handing
over runtime state to consuming methods in favor
of parking them on $this.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Christian Kuhn commented on patch set 1 08/30/23, 16:50

    Cherry Picked from branch main.
  2. Stefan Bürk voted on patch set 1 V +1 CR +1 08/30/23, 16:53

  3. Christian Kuhn uploaded patch set 2 CR +1 V +1 08/30/23, 16:57

  4. core-ci voted on patch set 1 V -1 08/30/23, 17:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46055

  5. core-ci voted on patch set 2 V +1 08/30/23, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46056

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 08/30/23, 17:07

  7. Christian Kuhn merged patch set 3 08/30/23, 17:07