80692[BUGFIX] Hide form validators label when no one is available
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 4
- Build/Sources/TypeScript/form/backend/form-editor/inspector-component.ts+15 −2
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/FinishersEditor.html+2 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/ValidatorsEditor.html+2 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/inspector-component.js+1 −1
Review log 1316
-
Benjamin Franzke uploaded patch set 1 08/25/23, 05:07
-
core-ci voted on patch set 1 V +1 08/25/23, 05:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45819
-
Andreas Kienast commented on patch set 1 08/25/23, 06:12
helpful -
Benjamin Franzke updated the commit message in patch set 2
V +108/25/23, 06:16Fix typo -
Benjamin Franzke commented on patch set 2 08/25/23, 06:16
Reply
Done -
Andreas Kienast voted on patch set 2 V +1 CR +1 08/25/23, 06:17
-
core-ci voted on patch set 2 V +1 08/25/23, 06:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45820
-
Christian Kuhn voted on patch set 2 V +1 08/28/23, 08:58
-
Benjamin Kott commented on patch set 2 CR -1 08/29/23, 08:14
1. form element is not removed completely 2. when validators are existing but not available anymore for selection the "label" is missing and the user has no idea what the entries are for -
Benjamin Franzke uploaded patch set 3
CR +1V +109/06/23, 08:06 -
Benjamin Franzke commented on patch set 3 09/06/23, 08:06
Reply
Thanks, good point! We can not remove .form-editor, as the helper API doesn't allow that. But I've adapted to remove the contents. I've adapted the code to show a non <label> element (<label> had to be removed as it's invalid to output a label without an associated input/select field) for the validators (when they exist) when the select element is removed. -
core-ci voted on patch set 3 V +1 09/06/23, 08:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46269
-
Benjamin Kott voted on patch set 3 V +1 CR +1 09/06/23, 08:24
-
Benni Mack voted on patch set 3 V +1 CR +1 09/07/23, 05:37
-
Benjamin Franzke voted on patch set 3 V +2 CR +2 09/07/23, 05:39
-
Benjamin Franzke merged patch set 4 09/07/23, 05:39