Review main Merged

80699[TASK] Improve CKEditor vendor logo placement

Torben Hansen CR +2 V +2 Easy +10 −1 updated 08/26/23, 20:09

Commit message

With CKEditor v38.0.0 a small "Powered by CKEditor" logo has been added
to the bottom right of the editor component. The logo is visible as soon
as the CKEditor component receives the focus. The current placement of
the logo does however overlay the border of the editor component and the
term "Powered by" does not suit well to the TYPO3 backend.

With this change, the CKEditor configuration has been extended, so it is
now possible to configure `config.ui.*` settings. The `Base.yaml` file
has been extended with CKEditor UI specific settings, which remove the
term "Powered by" from the logo and which optimize the logo placement,
so it appears in the bottom right corner of the editor component without
overlaying the border.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Benjamin Franzke +1
    • Thomas Hohn +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Torben Hansen uploaded patch set 1 08/26/23, 11:01

  2. core-ci voted on patch set 1 V +1 08/26/23, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45851

  3. Thomas Hohn voted on patch set 1 CR +1 08/26/23, 15:51

  4. Benjamin Franzke voted on patch set 1 V +1 CR +1 08/26/23, 16:41

  5. Jasmina Ließmann voted on patch set 1 V +2 CR +2 08/26/23, 20:09

  6. Jasmina Ließmann merged patch set 2 08/26/23, 20:09