Review main Merged

80700[TASK] Use CPP in ModifyRecordListHeaderColumnsEvent

Torben Hansen CR +2 V +2 Easy +9 −19 updated 08/26/23, 16:45

Commit message

With this change, CPP is used in ModifyRecordListHeaderColumnsEvent.

Additionally, 2 superfluous type declarations have been removed
from the doc comments, since the setColumn() function already uses
PHP native type parameters.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Torben Hansen uploaded patch set 1 08/26/23, 11:59

  2. core-ci voted on patch set 1 V +1 08/26/23, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45853

  3. Torben Hansen updated the commit message in patch set 2 V +1 08/26/23, 12:13

  4. core-ci voted on patch set 2 V +1 08/26/23, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45855

  5. Oliver Klee voted on patch set 2 V +1 CR +1 08/26/23, 12:53

  6. Benjamin Franzke voted on patch set 2 V +2 CR +2 08/26/23, 16:45

  7. Benjamin Franzke merged patch set 3 08/26/23, 16:45