Review main Merged

80703[TASK] Replace chosen-js with select-pure

Benjamin Franzke CR +2 V +2 Expert +358 −709 updated 08/30/23, 15:19

Commit message

chosen-js is based on jQuery, while select-pure is
based on lit and is therefore available as web components.
This is a better fit for our current development model.

Commands executed:
  npm remove chosen-js @types/chosen-js
  npm install --save select-pure
  grunt build

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 21

Review log 1419

  1. Benjamin Franzke uploaded patch set 1 08/26/23, 13:58

  2. Oliver Klee commented on patch set 1 08/26/23, 14:05

    I propose to explain the rationale for this change in the commit message. I think copying the text from the ticket should suffice.
  3. core-ci voted on patch set 1 V +1 08/26/23, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45858

  4. Benjamin Franzke updated the commit message in patch set 2 V +1 08/26/23, 15:08

    Add rationale
  5. Benjamin Franzke commented on patch set 2 08/26/23, 15:08

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 08/26/23, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45859

  7. Benjamin Franzke rebased onto patch set 3 V +1 08/28/23, 10:58

  8. core-ci voted on patch set 3 V +1 08/28/23, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45891

  9. Andreas Kienast commented on patch set 3 08/28/23, 12:07

    Another overlooked bug that already occurs before the patch: in "Upgrade Docs", the filter is not properly reset when filtering by tags and removing that filter again.
  10. Andreas Kienast voted on patch set 3 V +1 CR +1 08/28/23, 12:07

  11. Andreas Kienast uploaded patch set 4 CR +1 V +1 08/28/23, 12:59

  12. Andreas Kienast voted on patch set 4 V +1 CR +1 08/28/23, 13:00

  13. core-ci voted on patch set 4 V +1 08/28/23, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45897

  14. Benjamin Franzke uploaded patch set 5 CR +1 V +1 08/29/23, 16:35

    Rebase
  15. core-ci voted on patch set 5 V +1 08/29/23, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45991

  16. Andreas Kienast voted on patch set 5 V +1 CR +1 08/30/23, 05:36

  17. Christian Kuhn voted on patch set 5 V +1 CR +1 08/30/23, 15:18

  18. Stefan Bürk voted on patch set 5 V +2 CR +2 08/30/23, 15:18

  19. Stefan Bürk merged patch set 6 08/30/23, 15:19