80703[TASK] Replace chosen-js with select-pure
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 21
- Build/Sources/Sass/libs/_chosen.scssdeleted+0 −457
- Build/Sources/Sass/libs/_selectpure.scssnew+30 −0
- Build/Sources/Sass/backend.scss+2 −2
- Build/Sources/TypeScript/install/module/settings/system-maintainer.ts+5 −46
- Build/Sources/TypeScript/install/module/upgrade/upgrade-docs.ts+23 −45
- Build/types/TYPO3/index.d.ts+0 −1
- Build/Gruntfile.js+37 −20
- Build/package-lock.json+19 −35
- Build/package.json+1 −2
- Build/tsconfig.json+0 −1
- typo3/sysext/backend/Configuration/JavaScriptModules.php+1 −0
- typo3/sysext/backend/Resources/Private/Partials/About/ExternalLibraries.html+4 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −68
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/select-pure.jsnew+202 −0
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/SettingsCest.php+5 −5
- typo3/sysext/install/Classes/Controller/SettingsController.php+10 −9
- typo3/sysext/install/Resources/Private/Templates/Settings/SystemMaintainer.html+10 −8
- typo3/sysext/install/Resources/Private/Templates/Upgrade/UpgradeDocsGetContent.html+5 −7
- typo3/sysext/install/Resources/Public/JavaScript/module/settings/system-maintainer.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/upgrade-docs.js+1 −1
Review log 1419
-
Benjamin Franzke uploaded patch set 1 08/26/23, 13:58
-
Oliver Klee commented on patch set 1 08/26/23, 14:05
I propose to explain the rationale for this change in the commit message. I think copying the text from the ticket should suffice. -
core-ci voted on patch set 1 V +1 08/26/23, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45858
-
Benjamin Franzke updated the commit message in patch set 2
V +108/26/23, 15:08Add rationale -
Benjamin Franzke commented on patch set 2 08/26/23, 15:08
Reply
Done -
core-ci voted on patch set 2 V +1 08/26/23, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45859
-
Benjamin Franzke rebased onto patch set 3
V +108/28/23, 10:58 -
core-ci voted on patch set 3 V +1 08/28/23, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45891
-
Andreas Kienast commented on patch set 3 08/28/23, 12:07
Another overlooked bug that already occurs before the patch: in "Upgrade Docs", the filter is not properly reset when filtering by tags and removing that filter again. -
Andreas Kienast voted on patch set 3 V +1 CR +1 08/28/23, 12:07
-
Andreas Kienast uploaded patch set 4
CR +1V +108/28/23, 12:59 -
Andreas Kienast voted on patch set 4 V +1 CR +1 08/28/23, 13:00
-
core-ci voted on patch set 4 V +1 08/28/23, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45897
-
Benjamin Franzke uploaded patch set 5
CR +1V +108/29/23, 16:35Rebase -
core-ci voted on patch set 5 V +1 08/29/23, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45991
-
Andreas Kienast voted on patch set 5 V +1 CR +1 08/30/23, 05:36
-
Christian Kuhn voted on patch set 5 V +1 CR +1 08/30/23, 15:18
-
Stefan Bürk voted on patch set 5 V +2 CR +2 08/30/23, 15:18
-
Stefan Bürk merged patch set 6 08/30/23, 15:19