Review main Merged

80705[BUGFIX] Fix installer password toggle icon rendering

Benjamin Franzke CR +2 V +2 Easy +25 −8 updated 08/28/23, 11:22

Commit message

The ajax Icon API is currently not available during
first install, therefore neither getIcon nor the
icon web component may be used to render an icon.
The icon markup is therefore now pre-rendered
via fluid for both states and toggled via CSS.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 710

  1. Benjamin Franzke uploaded patch set 1 08/27/23, 18:05

  2. core-ci voted on patch set 1 V +1 08/27/23, 18:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45866

  3. Benjamin Franzke rebased onto patch set 2 V +1 08/28/23, 08:13

    Rebase
  4. core-ci voted on patch set 2 V +1 08/28/23, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45878

  5. Christian Kuhn updated the commit message in patch set 3 V +1 08/28/23, 09:14

  6. core-ci voted on patch set 3 V +1 08/28/23, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45881

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 08/28/23, 09:49

  8. Andreas Kienast voted on patch set 3 V +1 CR +1 08/28/23, 11:12

  9. Benjamin Franzke voted on patch set 3 V +2 CR +2 08/28/23, 11:20

  10. Benjamin Franzke merged patch set 4 08/28/23, 11:22