Review 12.4 Merged

80712[BUGFIX] Fix installer password toggle icon rendering

Benjamin Franzke CR +2 V +2 Easy +25 −8 updated 08/28/23, 11:34

Commit message

The ajax Icon API is currently not available during
first install, therefore neither getIcon nor the
icon web component may be used to render an icon.
The icon markup is therefore now pre-rendered
via fluid for both states and toggled via CSS.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 5

Review log 23

  1. Benjamin Franzke uploaded patch set 1 08/28/23, 11:22

  2. core-ci voted on patch set 1 V +1 08/28/23, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45892

  3. Benjamin Franzke merged patch set 2 08/28/23, 11:34