Review 12.4 Merged

80714[BUGFIX] Listen to correct events in "Extension Configuration" filter

Andreas Kienast CR +2 V +2 Easy +25 −18 updated 08/28/23, 19:18

Commit message

Previously, the `keyup` event was intercepted in "Extension
Configuration", which doesn't work with `clearable()`. This patch
changes the code to listen to `input` and `change` events instead.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Andreas Kienast uploaded patch set 1 08/28/23, 12:54

  2. core-ci voted on patch set 1 V +1 08/28/23, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45896

  3. Benjamin Franzke commented on patch set 1 V +1 CR +1 08/28/23, 18:32

    Works! Note for other reviewers: Has implicitly been fixed for main in https://review.typo3.org/c/Packages/TYPO3.CMS/+/80516
  4. Christian Kuhn voted on patch set 1 V +1 CR +1 08/28/23, 18:47

  5. Benjamin Franzke voted on patch set 1 V +2 CR +2 08/28/23, 19:18

  6. Benjamin Franzke merged patch set 2 08/28/23, 19:18