80730[BUGFIX] Hide form validators label when no one is available
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
-
Verified V +2 Done
- Benjamin Franzke +2
- core-ci +1 CI
Issues 2
Files 4
- Build/Sources/TypeScript/form/backend/form-editor/inspector-component.ts+15 −2
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/FinishersEditor.html+2 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/ValidatorsEditor.html+2 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/inspector-component.js+1 −1
Review log 810
-
Benjamin Franzke uploaded patch set 1 08/28/23, 13:48
-
Benjamin Franzke voted on patch set 1 V 0 CR 0 08/28/23, 13:50
-
core-ci voted on patch set 1 V +1 08/28/23, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45916
-
Benjamin Kott commented on patch set 1 CR -1 08/29/23, 08:13
1. form element is not removed completly 2. when validators are existing but not available anymore for selection the "label" is missing and the user has no idea what the entries are for -
Benjamin Franzke uploaded patch set 2
CR -1V +109/07/23, 04:36 -
Benjamin Franzke commented on patch set 1 09/07/23, 04:37
Reply
Done -
core-ci voted on patch set 2 V +1 09/07/23, 04:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46317
-
Benjamin Franzke marked it work in progress 09/07/23, 05:23
-
Benjamin Franzke commented on patch set 2 V +2 CR +2 09/07/23, 05:40
This change is ready for review. -
Benjamin Franzke merged patch set 3 09/07/23, 05:40