Review main Merged

80731[TASK] Ensure short list syntax is used

Torben Hansen CR +2 V +2 Easy +2 −1 updated 08/28/23, 18:33

Commit message

With #90002, all occurrences of the `list()` function have been migrated
to the short list syntax. Our php-cs-fixer configuration does however
not check the short list syntax usage, so we have one usage of `list()`
in our codebase again.

This change extends the php-cs-fixer configuration to ensure, that
only the short list syntax is used. The new ruleset has been applied
to the codebase and one usage of the `list()` function has been migrated.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 57

  1. Torben Hansen uploaded patch set 1 08/28/23, 13:53

  2. Christian Kuhn updated the commit message in patch set 2 08/28/23, 14:10

  3. Oliver Klee voted on patch set 2 V +1 CR +1 08/28/23, 14:23

  4. core-ci voted on patch set 1 V +1 08/28/23, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45917

  5. core-ci voted on patch set 2 V +1 08/28/23, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45920

  6. Benjamin Franzke voted on patch set 2 V +2 CR +2 08/28/23, 18:18

  7. Benjamin Franzke merged patch set 3 08/28/23, 18:33