Review 11.5 Merged

80734[BUGFIX] Hide form validators label when no one is available

Benjamin Franzke CR +2 V +2 Easy +21 −5 updated 09/07/23, 05:40

Commit message

With the deprecation removal of regular expressions
based EXT:form validators in #101070, the set of available
validators for the form element type URL became empty.
(See EXT:form/Configuration/Yaml/FormElements/Url.yaml)

Instead of only removing the select element from the DOM,
the entire form-group is now removed, in order to also hide
the corresponding <label> tag, as such a stray label tag
isn't helpful for an enduser and is therefore actually even
invalid HTML (as the reference to an input element is missing).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 68

  1. Benjamin Franzke uploaded patch set 1 08/28/23, 15:02

  2. core-ci voted on patch set 1 V +1 08/28/23, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45922

  3. Benjamin Franzke voted on patch set 1 CR -1 09/07/23, 04:37

  4. Benjamin Franzke uploaded patch set 2 CR -1 V +1 09/07/23, 04:48

  5. core-ci voted on patch set 2 V +1 09/07/23, 04:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46318

  6. Benjamin Franzke marked it work in progress 09/07/23, 05:23

  7. Benjamin Franzke commented on patch set 2 V +2 CR +2 09/07/23, 05:40

    This change is ready for review.
  8. Benjamin Franzke merged patch set 3 09/07/23, 05:40