80735[BUGFIX] Avoid static state in LocalizationUtility
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benjamin Franzke +1
- Thomas Hohn +1
- Garvin Hicking +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benjamin Franzke +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1318
-
Christian Kuhn uploaded patch set 1 08/28/23, 15:51
-
core-ci voted on patch set 1 V -1 08/28/23, 15:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45924
-
Christian Kuhn updated the commit message in patch set 2
V -108/28/23, 16:15 -
core-ci voted on patch set 2 V -1 08/28/23, 16:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45927
-
Christian Kuhn uploaded patch set 3
V -108/28/23, 16:30 -
core-ci voted on patch set 3 V +1 08/28/23, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45928
-
Benjamin Franzke voted on patch set 3 CR +1 08/28/23, 16:56
-
Christian Kuhn uploaded patch set 4
CR +1V +108/28/23, 17:31 -
core-ci voted on patch set 4 V +1 08/28/23, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45930
-
Christian Kuhn updated the commit message in patch set 5
V +108/28/23, 18:10 -
Benjamin Franzke voted on patch set 5 V +1 CR +1 08/28/23, 18:14
-
Oliver Klee commented on patch set 5 08/28/23, 18:20
-
core-ci voted on patch set 5 V +1 08/28/23, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45935
-
Thomas Hohn voted on patch set 5 CR +1 08/28/23, 18:29
-
Christian Kuhn commented on patch set 5 08/28/23, 18:31
LocalizationUtilityTest.php:36Replybad idea, imho: a) state / properties in tests should be avoided whenever possible. b) setUp() should be avoided whenever possible c) we're actively getting rid of 'accessible mocks' and 'partial mocks' and 'mocks of the system under test'. all those suck. d) better have code duplication in tests for simplicity than abstraction. tests should be simple. that's one reason in remove setUp() wherever i can since years already. it helps: they become more easy and more easy to refactor. tests must not be a hindrance to refactor SuT, but a help to verify SuT refactorings are ok. -> no mock configuration of this detail in setUp(). -
Garvin Hicking voted on patch set 5 V +1 CR +1 08/28/23, 19:27
-
Christian Kuhn voted on patch set 5 V +2 CR +2 08/28/23, 19:32
-
Christian Kuhn merged patch set 6 08/28/23, 19:33
LocalizationUtilityTest.php:36