Review main Merged

80741[TASK] Fix npm copy of contrib packages

Benjamin Franzke CR +2 V +2 Easy +17 −11 updated 08/29/23, 12:16

Commit message

@lezer/common – in contrast to other @lezer modules,
is placed in dist/index.js instead of dist/index.es.js.
Therefore we add a distinct copy rule.

The sortablejs npm package recently changed to provide both,
a UMD bundle and a native ESM module.
As we actually failed to update the UMD bundle (due to a
rename of the build output filename in sortablejs),
we switch to the new ESM variant right away.

muuri failed to update because dashboardToEs6
was missing in the npmcopy concurrent target.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 4

Files 4

Review log 56

  1. Benjamin Franzke uploaded patch set 1 08/29/23, 07:13

  2. core-ci voted on patch set 1 V +1 08/29/23, 07:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45952

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 08/29/23, 07:44

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 08/29/23, 10:56

  5. Andreas Kienast voted on patch set 1 V +2 CR +2 08/29/23, 12:16

  6. Andreas Kienast merged patch set 2 08/29/23, 12:16