Review 12.4 Merged

80745[TASK] Use URL API in Install Tool router

Benjamin Franzke CR +2 V +2 Easy +12 −14 updated 08/29/23, 10:03

Commit message

The Install Tool router attempts to build URLs manually by wild string
replacements and manipulation, which is rather error-prone. This patch
changes the approach to use the URL API instead.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 23

  1. Benjamin Franzke uploaded patch set 1 08/29/23, 09:38

  2. core-ci voted on patch set 1 V +1 08/29/23, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45963

  3. Benjamin Franzke merged patch set 2 08/29/23, 10:03