Review main Merged

80749[TASK] Migrate helper entry point scripts to TypeScript

Benjamin Franzke CR +2 V +2 Hard +198 −144 updated 09/04/23, 12:36

Commit message

Now that our build chain targets ESM modules, we can
use our TypeScript toolchain to also build utility
entry point scripts, allowing to make use of TypeScript
checking and centralize asset management.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 18

Review log 1013

  1. Benjamin Franzke uploaded patch set 1 08/29/23, 13:06

  2. core-ci voted on patch set 1 V +1 08/29/23, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45982

  3. Benjamin Franzke uploaded patch set 2 V +1 08/29/23, 14:14

  4. core-ci voted on patch set 2 V +1 08/29/23, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45984

  5. Andreas Kienast commented on patch set 2 08/30/23, 05:03

    close-current-window.ts:2

    This could be removed in the same run, what do you think?
  6. Benjamin Franzke commented on patch set 2 08/30/23, 15:33

    close-current-window.ts:2 Reply

    I don't exactly know how? I mean it is somewhat awkward to reload the opener, but i haven't digged deeper into that.
  7. Benjamin Franzke uploaded patch set 3 V +1 08/31/23, 07:59

  8. Benjamin Franzke commented on patch set 3 08/31/23, 07:59

    close-current-window.ts:2 Reply

    Remove the `true` parameter which is not used by any browser.
  9. core-ci voted on patch set 3 V +1 08/31/23, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46068

  10. Andreas Kienast voted on patch set 3 V +1 CR +1 09/04/23, 07:16

  11. Benni Mack voted on patch set 3 V +1 CR +1 09/04/23, 08:04

  12. Benjamin Franzke voted on patch set 3 V +2 CR +2 09/04/23, 09:30

  13. Benjamin Franzke merged patch set 4 09/04/23, 12:36