Review main Merged

80751[TASK] Refactor install tool module selectors to enums

Andreas Nedbal CR +2 V +2 Hard +446 −407 updated 09/07/23, 08:47

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 48

Show 28 more files

Review log 1115

  1. Andreas Nedbal uploaded patch set 1 08/29/23, 16:20

  2. core-ci voted on patch set 1 V +1 08/29/23, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45990

  3. Benjamin Franzke commented on patch set 1 08/29/23, 16:33

    environment-check.ts:49

    Probably an error after rebasing on the "Define readonly for never-written private TypeScript variables" patch. These should be unused and removed, right?
  4. Andreas Nedbal uploaded patch set 2 V +1 08/29/23, 17:55

  5. Andreas Nedbal commented on patch set 2 08/29/23, 17:56

    environment-check.ts:49 Reply

    Done
  6. core-ci voted on patch set 2 V +1 08/29/23, 18:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45992

  7. Andreas Nedbal uploaded patch set 3 V +1 09/06/23, 21:52

  8. core-ci voted on patch set 3 V +1 09/06/23, 21:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46312

  9. Andreas Kienast commented on patch set 3 CR -1 09/07/23, 08:16

    Apparently there are some selectors that don't do anything anymore. Will take care.
  10. Andreas Kienast uploaded patch set 4 CR -1 V +1 09/07/23, 08:37

  11. Benjamin Franzke voted on patch set 4 CR +1 09/07/23, 08:39

  12. Benjamin Franzke voted on patch set 4 V +1 09/07/23, 08:40

  13. core-ci voted on patch set 4 V +1 09/07/23, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46332

  14. Andreas Kienast voted on patch set 4 V +2 CR +2 09/07/23, 08:46

  15. Andreas Kienast merged patch set 5 09/07/23, 08:47