Review main Merged

80752[TASK] Remove DataHandler->checkStoredRecord()

Christian Kuhn CR +2 V +2 Normal +82 −114 updated 08/30/23, 08:30

Commit message

Well, that functionality is hilarious: Sometimes,
when the DataHandler updates or inserts database
rows, it calls checkStoredRecord() which fetches
the just written row to verify the row has
actually been written correctly.

* The implementation is inconsistent, DH does
  not do this for all update queries.
* The default configuration is to fetch the row,
  but to *not* check the fields, rendering the
  entire thing useless, but still have the
  additional query.
* *If* DH would actually find some collision, it
  will bury that information as entry in sys_log.
* We fiddled with this in #79438 for v8 already to
  allow suppressing overhead via TYPO3_CONF_VARS.
  These toggles are widely unknown and most likely
  used very seldom.
* Inserting invalid data a DB can not persist most
  likely raises doctrine exceptions, especially with
  many database instances being configured in "strict"
  mode nowadays.
* With our current efforts to configure database
  columns automatically by auto-creating them from
  TCA, we further reduce the risk of columns not
  being configured correctly for given data.

The patch:

* Removes (@internal) DataHandler->checkStoredRecord()
* Keeps two related DataHandler properties as b/w
  compat layer, but renders them unused.
* Removes two related TYPO3_CONF_VARS.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 6

Review log 810

  1. Christian Kuhn uploaded patch set 1 08/30/23, 00:41

  2. core-ci voted on patch set 1 V +1 08/30/23, 00:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46005

  3. Christian Kuhn uploaded patch set 2 V +1 08/30/23, 01:31

  4. core-ci voted on patch set 2 V +1 08/30/23, 01:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46007

  5. Andreas Kienast voted on patch set 2 CR +1 08/30/23, 05:34

  6. Stefan Bürk voted on patch set 2 CR +1 08/30/23, 06:14

  7. Stefan Bürk voted on patch set 2 V +1 08/30/23, 07:08

  8. Oliver Klee voted on patch set 2 V +1 CR +1 08/30/23, 08:21

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 08/30/23, 08:30

  10. Christian Kuhn merged patch set 3 08/30/23, 08:30