Review main Merged

80755[TASK] Migrate @typo3/t3editor/autocomplete/* to TypeScript

Benjamin Franzke CR +2 V +2 Expert +913 −935 updated 09/01/23, 17:34

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 11

Review log 1214

  1. Benjamin Franzke uploaded patch set 1 08/30/23, 09:25

    git mv
  2. Benjamin Franzke uploaded patch set 2 08/30/23, 09:26

    Apply eslint fix
  3. Benjamin Franzke uploaded patch set 3 08/30/23, 09:26

    Manual eslint fixes
  4. Benjamin Franzke uploaded patch set 4 08/30/23, 09:27

    Define types
  5. Andreas Kienast commented on patch set 4 08/30/23, 09:32

    completion-result.ts:49

    I think @param and @return can be removed

    typoscript.ts:46

    That's smart!
  6. core-ci voted on patch set 4 V +1 08/30/23, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46028

  7. Andreas Kienast commented on patch set 4 08/30/23, 09:40

    ts-code-completion.ts:146

    Method is unused

    ts-ref.ts:104

    `return` is superfluous

    typoscript.ts:95

    Just found this. Smack it!
  8. Benjamin Franzke uploaded patch set 5 V +1 08/30/23, 15:23

    Cleanups
  9. Benjamin Franzke commented on patch set 5 08/30/23, 15:23

    completion-result.ts:49 Reply

    Done

    ts-code-completion.ts:146 Reply

    Thanks, removed.

    ts-ref.ts:104 Reply

    Done

    typoscript.ts:46 Reply

    Ack

    typoscript.ts:95 Reply

    Done
  10. core-ci voted on patch set 5 V +1 08/30/23, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46043

  11. Andreas Kienast voted on patch set 5 V +1 CR +1 08/31/23, 06:33

  12. Christian Kuhn voted on patch set 5 V +1 CR +1 09/01/23, 16:39

  13. Benjamin Franzke voted on patch set 5 V +2 CR +2 09/01/23, 17:25

  14. Benjamin Franzke merged patch set 6 09/01/23, 17:34