80755[TASK] Migrate @typo3/t3editor/autocomplete/* to TypeScript
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Christian Kuhn +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 11
- Build/Sources/TypeScript/t3editor/autocomplete/completion-result.ts2new+105 −0
- Build/Sources/TypeScript/t3editor/autocomplete/ts-code-completion.ts2new+142 −0
- Build/Sources/TypeScript/t3editor/autocomplete/ts-parser.tsnew+485 −0
- Build/Sources/TypeScript/t3editor/autocomplete/ts-ref.ts2new+164 −0
- Build/Sources/TypeScript/t3editor/language/typoscript.ts4+12 −6
- Build/types/TYPO3/index.d.ts+0 −1
- typo3/sysext/t3editor/Resources/Public/JavaScript/autocomplete/completion-result.js+1 −109
- typo3/sysext/t3editor/Resources/Public/JavaScript/autocomplete/ts-code-completion.js+1 −148
- typo3/sysext/t3editor/Resources/Public/JavaScript/autocomplete/ts-parser.js+1 −505
- typo3/sysext/t3editor/Resources/Public/JavaScript/autocomplete/ts-ref.js+1 −165
- typo3/sysext/t3editor/Resources/Public/JavaScript/language/typoscript.js+1 −1
Review log 1214
-
Benjamin Franzke uploaded patch set 1 08/30/23, 09:25
git mv -
Benjamin Franzke uploaded patch set 2 08/30/23, 09:26
Apply eslint fix -
Benjamin Franzke uploaded patch set 3 08/30/23, 09:26
Manual eslint fixes -
Benjamin Franzke uploaded patch set 4 08/30/23, 09:27
Define types -
Andreas Kienast commented on patch set 4 08/30/23, 09:32
completion-result.ts:49I think @param and @return can be removedtyposcript.ts:46That's smart! -
core-ci voted on patch set 4 V +1 08/30/23, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46028
-
Andreas Kienast commented on patch set 4 08/30/23, 09:40
ts-code-completion.ts:146Method is unusedts-ref.ts:104`return` is superfluoustyposcript.ts:95Just found this. Smack it! -
Benjamin Franzke uploaded patch set 5
V +108/30/23, 15:23Cleanups -
Benjamin Franzke commented on patch set 5 08/30/23, 15:23
completion-result.ts:49ReplyDonets-code-completion.ts:146ReplyThanks, removed.ts-ref.ts:104ReplyDonetyposcript.ts:46ReplyAcktyposcript.ts:95ReplyDone -
core-ci voted on patch set 5 V +1 08/30/23, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46043
-
Andreas Kienast voted on patch set 5 V +1 CR +1 08/31/23, 06:33
-
Christian Kuhn voted on patch set 5 V +1 CR +1 09/01/23, 16:39
-
Benjamin Franzke voted on patch set 5 V +2 CR +2 09/01/23, 17:25
-
Benjamin Franzke merged patch set 6 09/01/23, 17:34