80756[BUGFIX] Replace CSP mutation mode extend by inherit & append
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Benjamin Franzke +1
- Stefan Bürk +1
-
Verified V +2 Done
- Oliver Hader +2
- Benjamin Franzke +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/backend/Configuration/ContentSecurityPolicies.php+18 −0
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/MutationMode.php+30 −4
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/Policy.php+39 −9
- typo3/sysext/core/Configuration/ContentSecurityPolicies.phpdeleted+0 −42
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-99499-IntroduceContent-Security-PolicyHandling.rst+8 −0
- typo3/sysext/core/Tests/Functional/Security/ContentSecurityPolicy/PolicyTest.php+54 −0
- typo3/sysext/frontend/Configuration/ContentSecurityPolicies.php+18 −0
Review log 2028
Show 23 earlier messages
-
Oliver Hader uploaded patch set 1 08/30/23, 11:29
-
core-ci voted on patch set 1 V -1 08/30/23, 11:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46031
-
Oliver Hader uploaded patch set 2
V -108/30/23, 15:26
-
Oliver Hader wrote 08/30/23, 15:31
Topic set to csp -
Oliver Hader uploaded patch set 3 08/30/23, 15:35
-
core-ci voted on patch set 3 V -1 08/30/23, 15:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46051
-
Oliver Hader commented on patch set 3 CR -1 08/30/23, 17:18
Fails, since order of packages is not reflecting the dependency hierarchy - most of that information is actually not available in `composer.json`. Thus, my assumption, it would have been ordered is wrong... For instance `ext:extensionmanager` is processed before `ext:backend` - it actually should have a dependency to `ext:backend`, which does not exist. Without having a reliable order, any inheritance chain does not work. -
Oliver Hader uploaded patch set 4
CR -1V -108/30/23, 17:49 -
core-ci voted on patch set 4 V -1 08/30/23, 17:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46057
-
Oliver Hader commented on patch set 4 CR -1 08/31/23, 11:52
→ package dependency ordering: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80764 -
Oliver Hader rebased onto patch set 5
CR -1V -108/31/23, 13:46 -
core-ci voted on patch set 5 V -1 08/31/23, 14:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46102
-
Oliver Hader uploaded patch set 6
V -108/31/23, 14:19 -
core-ci voted on patch set 6 V +1 08/31/23, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46107
-
Oliver Hader commented on patch set 6 08/31/23, 14:30
This change is ready for review. -
Oliver Hader uploaded patch set 7
V +109/19/23, 14:18 -
core-ci voted on patch set 7 V +1 09/19/23, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46794
-
Oliver Hader uploaded patch set 8
V +109/19/23, 17:32 -
core-ci voted on patch set 8 V +1 09/19/23, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46809
-
Oliver Hader rebased onto patch set 9
V +109/20/23, 09:43 -
core-ci voted on patch set 9 V +1 09/20/23, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46865
-
Stefan Bürk voted on patch set 9 CR +1 09/20/23, 18:57
-
Stefan Bürk voted on patch set 9 V +1 10/17/23, 07:53
-
Benjamin Franzke commented on patch set 9 CR +1 10/26/23, 07:25
I would prefer we had some kind of "late static binding" extensions, that says: "whatever is changed on the ancestor sometime later, please inherit" Maybe that could be "InheritStatic". Anyway I'm still fine with this patch as is. -
Benjamin Franzke voted on patch set 9 V +1 10/26/23, 07:36
-
Oliver Hader voted on patch set 9 V +2 CR +2 10/26/23, 08:28
-
Oliver Hader merged patch set 10 10/26/23, 08:29
-
Oliver Hader commented on patch set 10 10/26/23, 08:31
Reply
Thx. I've create a new issue at https://forge.typo3.org/issues/102262Thx folks, for your reviews & tests!