Review main Merged

80758[TASK] Deprecate EMU::addPageTSConfig()

Christian Kuhn CR +2 V +2 Hard +262 −117 updated 08/30/23, 14:23

Commit message

ExtensionManagementUtility::addPageTSConfig() has
been superseded in v12 with feature #96614 already,
which allows autoloading Configuration/page.tsconfig
files.

To further reduce ExtensionManagementUtility,
ext_localconf.php files and TYPO3_CONF_VARS, the
old way is now marked as deprecated.

The patch does that, documents the impact and
refactors a couple of tests to deal with this
as well.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 14

Review log 811

  1. Christian Kuhn uploaded patch set 1 08/30/23, 12:16

  2. core-ci voted on patch set 1 V +1 08/30/23, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46034

  3. Christian Kuhn uploaded patch set 2 V +1 08/30/23, 12:48

  4. core-ci voted on patch set 2 V +1 08/30/23, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46035

  5. Christian Kuhn uploaded patch set 3 V +1 08/30/23, 13:12

  6. core-ci voted on patch set 3 V +1 08/30/23, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46036

  7. Garvin Hicking commented on patch set 3 CR +1 08/30/23, 13:19

    (Can't comment/review on the tests yet, deprecation appreciated :) )
  8. Oliver Klee voted on patch set 3 V +1 CR +1 08/30/23, 13:27

  9. Stefan Bürk voted on patch set 3 CR +1 08/30/23, 13:43

  10. Stefan Bürk voted on patch set 3 V +2 CR +2 08/30/23, 14:23

  11. Stefan Bürk merged patch set 4 08/30/23, 14:23