Review main Merged

80760[BUGFIX] Fix stage changing in workspace preview

Christian Kuhn CR +2 V +2 Easy +3 −4 updated 08/30/23, 14:46

Commit message

Changing stages using the various buttons in
workspace preview module fatals server side
since the request is incomplete.

This is mainly due to the weird ajax dispatching
from class AjaxDispatcher to ActionHandler: This
area needs a major overhaul.

However, patch for issue #100577 already introduced
a hack to hand the current request down. The patch
re-uses this to fix the issue.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 4

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 08/30/23, 14:27

  2. Andreas Kienast voted on patch set 1 V +1 CR +1 08/30/23, 14:30

  3. core-ci voted on patch set 1 V +1 08/30/23, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46038

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 08/30/23, 14:37

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 08/30/23, 14:45

  6. Christian Kuhn merged patch set 2 08/30/23, 14:46