Review main Merged

80767[FEATURE] Allow `Configuration/user.tsconfig`

Christian Kuhn CR +2 V +2 Hard +302 −148 updated 03/20/24, 06:11

Commit message

Similar to `Configuration/page.tsconfig`,
default User TSconfig is now loaded from
extensions `Configuration/user.tsconfig` files.

ExtensionManagementUtility::addUserTSConfig()
is deprecated similar to the page TSconfig
patch from #101799.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stephan Großberndt +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 29

Show 9 more files

Review log 1824

  1. Christian Kuhn uploaded patch set 1 08/31/23, 08:02

  2. core-ci voted on patch set 1 V +1 08/31/23, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46069

  3. Christian Kuhn uploaded patch set 2 V +1 08/31/23, 09:03

  4. core-ci voted on patch set 2 V -1 08/31/23, 09:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46072

  5. Christian Kuhn uploaded patch set 3 V -1 08/31/23, 09:17

  6. Christian Kuhn uploaded patch set 4 08/31/23, 09:18

  7. core-ci voted on patch set 4 V -1 08/31/23, 09:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46075

  8. core-ci voted on patch set 3 V -1 08/31/23, 09:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46074

  9. Christian Kuhn uploaded patch set 5 V -1 08/31/23, 09:40

  10. Christian Kuhn uploaded patch set 6 08/31/23, 09:45

  11. core-ci voted on patch set 5 V -1 08/31/23, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46077

  12. core-ci voted on patch set 6 V +1 08/31/23, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46078

  13. Markus Klein commented on patch set 6 08/31/23, 10:27

    I would actually to have this in Configuration/TsConfig/user.tsconfig.
  14. Markus Klein commented on patch set 6 08/31/23, 10:28

    https://github.com/FriendsOfTYPO3/tea/tree/main/Configuration As you can see the best practice is to have a TscConfig folder. Which I deem really reasonable.
  15. Markus Klein commented on patch set 6 08/31/23, 10:28

    Same goes for page.tsconfig btw.
  16. Stefan Bürk voted on patch set 6 V +1 CR +1 08/31/23, 12:05

  17. Christian Kuhn commented on patch set 6 08/31/23, 12:25

    Reply

    The proposed patch follows what has been done with page.tsconfig in v12 already. If this is changed again, it needs to be a different patch. Furthermore, I think that Configuration/page.tsconfig and Configuration/user.tsconfig are good defaults. That's next to other files that are auto-loaded. If you need "more" because you're doing complex / lengthy stuff, you can always have some '@import ./tScOnFiG/*.tsconfig' in that file and follow whatever naming convention you think is useful for you.

    Reply

    Done
  18. Oliver Klee commented on patch set 6 08/31/23, 14:32

    user.tsconfig:1

    Where do the contents of this file come from?

    user.tsconfig:9

    Nitpick: In case this change is edited again, we should drop the extra blank line.
  19. Oliver Klee commented on patch set 6 V +1 CR +1 08/31/23, 14:36

    user.tsconfig:9 Reply

    No other changes needed, so let's skip this nitpick.
  20. Stephan Großberndt voted on patch set 6 CR +1 08/31/23, 14:50

  21. Christian Kuhn voted on patch set 6 V +2 CR +2 08/31/23, 14:50

  22. Christian Kuhn merged patch set 7 08/31/23, 14:51

  23. Stephan Großberndt commented on patch set 7 08/31/23, 14:52

    Feature-101807-AutomaticInclusionOfUserTSconfigOfExtensions.rst:31

    been been 🐝
  24. Christian Kuhn commented on patch set 7 03/20/24, 06:11

    Feature-101807-AutomaticInclusionOfUserTSconfigOfExtensions.rst:31 Reply

    Done