80767[FEATURE] Allow `Configuration/user.tsconfig`
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stephan Großberndt +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 3
Files 29
- typo3/sysext/adminpanel/Configuration/user.tsconfignew+4 −0
- typo3/sysext/adminpanel/ext_localconf.php+0 −8
- typo3/sysext/backend/Configuration/user.tsconfignew+22 −0
- typo3/sysext/backend/Tests/Functional/Fixtures/be_users_no_bookmarks.csvnew+4 −0
- typo3/sysext/backend/Tests/Functional/Template/Components/Buttons/Action/ShortcutButtonTest.php+1 −3
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TsConfigTreeBuilder.php+35 −0
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+5 −3
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −28
- typo3/sysext/core/Documentation/Changelog/13.0/Deprecation-101799-ExtensionManagementUtilityaddPageTSConfig.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/13.0/Deprecation-101807-ExtensionManagementUtilityaddUserTSConfig.rstnew+52 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-101807-AutomaticInclusionOfUserTSconfigOfExtensions.rst2new+36 −0
- typo3/sysext/core/Tests/Functional/Authentication/Fixtures/be_users.csv+9 −7
- typo3/sysext/core/Tests/Functional/Authentication/BackendUserAuthenticationTest.php+27 −59
- typo3/sysext/core/Tests/Functional/Authentication/GroupResolverTest.php+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DefaultValuesTest.php+3 −3
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/PagePermissionTest.php+4 −4
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_defaulttsconfig/Configuration/page.tsconfigrenamed+0 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_defaulttsconfig/Configuration/user.tsconfignew+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_defaulttsconfig/composer.jsonrenamed+2 −2
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_defaulttsconfig/ext_emconf.phprenamed+2 −2
Show 9 more files
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_typoscript_usertsconfigfactory/Configuration/user.tsconfignew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/UserTsConfigFactoryTest.php+3 −18
- typo3/sysext/core/Tests/FunctionalDeprecated/TypoScript/Fixtures/userTsConfigTestFixture.csvnew+3 −0
- typo3/sysext/core/Tests/FunctionalDeprecated/TypoScript/UserTsConfigFactoryTest.phpnew+55 −0
- typo3/sysext/filelist/Configuration/user.tsconfignew+8 −0
- typo3/sysext/frontend/Configuration/user.tsconfig4new+8 −0
- typo3/sysext/frontend/ext_localconf.php+0 −9
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
Review log 1824
-
Christian Kuhn uploaded patch set 1 08/31/23, 08:02
-
core-ci voted on patch set 1 V +1 08/31/23, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46069
-
Christian Kuhn uploaded patch set 2
V +108/31/23, 09:03 -
core-ci voted on patch set 2 V -1 08/31/23, 09:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46072
-
Christian Kuhn uploaded patch set 3
V -108/31/23, 09:17 -
Christian Kuhn uploaded patch set 4 08/31/23, 09:18
-
core-ci voted on patch set 4 V -1 08/31/23, 09:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46075
-
core-ci voted on patch set 3 V -1 08/31/23, 09:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46074
-
Christian Kuhn uploaded patch set 5
V -108/31/23, 09:40 -
Christian Kuhn uploaded patch set 6 08/31/23, 09:45
-
core-ci voted on patch set 5 V -1 08/31/23, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46077
-
core-ci voted on patch set 6 V +1 08/31/23, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46078
-
Markus Klein commented on patch set 6 08/31/23, 10:27
I would actually to have this in Configuration/TsConfig/user.tsconfig. -
Markus Klein commented on patch set 6 08/31/23, 10:28
https://github.com/FriendsOfTYPO3/tea/tree/main/Configuration As you can see the best practice is to have a TscConfig folder. Which I deem really reasonable. -
Markus Klein commented on patch set 6 08/31/23, 10:28
Same goes for page.tsconfig btw. -
Stefan Bürk voted on patch set 6 V +1 CR +1 08/31/23, 12:05
-
Christian Kuhn commented on patch set 6 08/31/23, 12:25
Reply
The proposed patch follows what has been done with page.tsconfig in v12 already. If this is changed again, it needs to be a different patch. Furthermore, I think that Configuration/page.tsconfig and Configuration/user.tsconfig are good defaults. That's next to other files that are auto-loaded. If you need "more" because you're doing complex / lengthy stuff, you can always have some '@import ./tScOnFiG/*.tsconfig' in that file and follow whatever naming convention you think is useful for you.Reply
Done -
Oliver Klee commented on patch set 6 08/31/23, 14:32
user.tsconfig:1Where do the contents of this file come from?user.tsconfig:9Nitpick: In case this change is edited again, we should drop the extra blank line. -
Oliver Klee commented on patch set 6 V +1 CR +1 08/31/23, 14:36
user.tsconfig:1Replyuser.tsconfig:9ReplyNo other changes needed, so let's skip this nitpick. -
Stephan Großberndt voted on patch set 6 CR +1 08/31/23, 14:50
-
Christian Kuhn voted on patch set 6 V +2 CR +2 08/31/23, 14:50
-
Christian Kuhn merged patch set 7 08/31/23, 14:51
-
Stephan Großberndt commented on patch set 7 08/31/23, 14:52
Feature-101807-AutomaticInclusionOfUserTSconfigOfExtensions.rst:31been been 🐝 -
Christian Kuhn commented on patch set 7 03/20/24, 06:11
Feature-101807-AutomaticInclusionOfUserTSconfigOfExtensions.rst:31ReplyDone