80768[TASK] Restore "ShowBlocks" functionality in CKEditor5
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benjamin Franzke +1
- Georg Ringer +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benjamin Franzke +1
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 6
- Build/Sources/JavaScript/rte_ckeditor/contrib/ckeditor5-bundle.js+2 −0
- Build/package-lock.json+14 −0
- Build/package.json+1 −0
- typo3/sysext/rte_ckeditor/Configuration/RTE/Full.yaml+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/en.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/ckeditor5-bundle.js+222 −96
Review log 913
-
Julian Mair uploaded patch set 1 08/31/23, 08:18
-
core-ci voted on patch set 1 V -1 08/31/23, 08:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46070
-
Julian Mair updated the commit message in patch set 2
V -108/31/23, 11:20 -
core-ci voted on patch set 2 V -1 08/31/23, 11:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46086
-
Julian Mair uploaded patch set 3
V -109/06/23, 11:15 -
core-ci voted on patch set 3 V +1 09/06/23, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46287
-
Benjamin Franzke uploaded patch set 4
V +109/07/23, 05:51 -
Benjamin Franzke commented on patch set 4 09/07/23, 05:51
FYI: We usually document the npm/grunt commands that were executed at the end of the commit message to make rebasing/cherry-picks easier. Added them now. -
core-ci voted on patch set 4 V +1 09/07/23, 05:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46320
-
Julian Mair commented on patch set 4 09/07/23, 12:27
Reply
Thank you, I highly appreciate your help -
Georg Ringer voted on patch set 4 V +1 CR +1 09/07/23, 12:29
-
Stefan Bürk voted on patch set 4 V +2 CR +2 09/07/23, 21:27
-
Stefan Bürk merged patch set 5 09/07/23, 21:27