Review main Merged

80768[TASK] Restore "ShowBlocks" functionality in CKEditor5

Julian Mair CR +2 V +2 Hard +241 −97 updated 09/07/23, 21:27

Commit message

With the initial upgrade to CKEditor5 in TYPO3 v12, the 'ShowBlocks'
plugin was not available upstream, so this feature got lost.

As of CKEditor5 v38.1.0 [1] the plugin has been reintroduced.
We include the plugin now and add it to the Full RTE preset
configuration by default.

Executed commands:
  npm install --save @ckeditor/ckeditor5-show-blocks@38.1.0
  grunt build

[1] https://github.com/ckeditor/ckeditor5/releases/tag/v38.1.0

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 913

  1. Julian Mair uploaded patch set 1 08/31/23, 08:18

  2. core-ci voted on patch set 1 V -1 08/31/23, 08:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46070

  3. Julian Mair updated the commit message in patch set 2 V -1 08/31/23, 11:20

  4. core-ci voted on patch set 2 V -1 08/31/23, 11:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46086

  5. Julian Mair uploaded patch set 3 V -1 09/06/23, 11:15

  6. core-ci voted on patch set 3 V +1 09/06/23, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46287

  7. Benjamin Franzke uploaded patch set 4 V +1 09/07/23, 05:51

  8. Benjamin Franzke commented on patch set 4 09/07/23, 05:51

    FYI: We usually document the npm/grunt commands that were executed at the end of the commit message to make rebasing/cherry-picks easier. Added them now.
  9. core-ci voted on patch set 4 V +1 09/07/23, 05:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46320

  10. Julian Mair commented on patch set 4 09/07/23, 12:27

    Reply

    Thank you, I highly appreciate your help
  11. Georg Ringer voted on patch set 4 V +1 CR +1 09/07/23, 12:29

  12. Stefan Bürk voted on patch set 4 V +2 CR +2 09/07/23, 21:27

  13. Stefan Bürk merged patch set 5 09/07/23, 21:27