Review main Merged

80794[TASK] Use @import instead of <INCLUDE_TYPOSCRIPT

Christian Kuhn CR +2 V +2 Normal +41 −37 updated 08/31/23, 14:11

Commit message

To be an example of best practice, this patch changes
all usages of "<INCLUDE_TYPOSCRIPT ..." to "@import".

Tests are adapted as well, as long as they are not
tailored to actually test INCLUDE_TYPOSCRIPT syntax.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Thomas Hohn +1
    • Oliver Klee +1
    • Garvin Hicking +1
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 89

  1. Christian Kuhn uploaded patch set 1 08/31/23, 13:26

  2. core-ci voted on patch set 1 V +1 08/31/23, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46097

  3. Andreas Kienast voted on patch set 1 CR +1 08/31/23, 13:40

  4. Oliver Klee voted on patch set 1 V +1 CR +1 08/31/23, 13:50

  5. Thomas Hohn voted on patch set 1 CR +1 08/31/23, 13:51

  6. Garvin Hicking commented on patch set 1 CR +1 08/31/23, 13:51

    <NICE>
  7. Oliver Hader voted on patch set 1 V +1 CR +1 08/31/23, 13:55

  8. Christian Kuhn voted on patch set 1 V +2 CR +2 08/31/23, 14:11

  9. Christian Kuhn merged patch set 2 08/31/23, 14:11