Review 11.5 Merged

80796[BUGFIX] Avoid strtotime(null) in BU::getProcessedValue()

Christian Kuhn CR +2 V +2 Normal +49 −2 updated 08/31/23, 14:02

Commit message

BackendUtility has a couple of strtotime() calls that
may end up as strtotime(null). This emits a PHP
E_DEPRECATED error since PHP 8.1. Add a cast.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Tiefenbrunn +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Tiefenbrunn +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Christian Kuhn uploaded patch set 1 08/31/23, 13:36

  2. core-ci voted on patch set 1 V +1 08/31/23, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46099

  3. Oliver Klee voted on patch set 1 V +1 CR +1 08/31/23, 13:52

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 08/31/23, 13:52

  5. Christian Kuhn merged patch set 2 08/31/23, 13:52

  6. Georg Tiefenbrunn commented on patch set 2 V +1 CR +1 08/31/23, 14:02

    Thanx for the quick fix!