Review main Merged

80816[TASK] Use new bootstrap Carousel interface in wizards elements

Benjamin Franzke CR +2 V +2 Normal +37 −27 updated 11/07/23, 09:38

Commit message

The jquery interface $().carousel() has an implicit dependency on
jquery being loaded, whenever bootstrap is loaded. To get rid
of jquery, we migrate to the newer vanilla js interface.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 1419

  1. Benjamin Franzke uploaded patch set 1 09/01/23, 13:47

  2. Benjamin Franzke voted on patch set 1 V -1 09/01/23, 13:50

  3. core-ci voted on patch set 1 V +1 09/01/23, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46139

  4. Benjamin Franzke voted on patch set 1 CR -1 09/01/23, 14:08

  5. Benjamin Franzke marked it work in progress 09/01/23, 14:09

  6. Benjamin Franzke uploaded patch set 2 CR -1 V +1 09/01/23, 16:21

  7. core-ci voted on patch set 2 V +1 09/01/23, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46153

  8. Benjamin Franzke rebased onto patch set 3 V +1 09/05/23, 20:00

  9. Benjamin Franzke marked it ready for review 09/05/23, 20:00

  10. core-ci voted on patch set 3 V +1 09/05/23, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46256

  11. Benjamin Franzke rebased onto patch set 4 V +1 09/11/23, 08:45

    Rebase
  12. core-ci voted on patch set 4 V +1 09/11/23, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46469

  13. Benjamin Franzke uploaded patch set 5 V +1 11/07/23, 07:52

    Rebase
  14. Andreas Kienast voted on patch set 5 V +1 CR +1 11/07/23, 07:58

  15. core-ci voted on patch set 5 V +1 11/07/23, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48676

  16. Benni Mack voted on patch set 5 CR +1 11/07/23, 08:32

  17. Benni Mack voted on patch set 5 V +1 11/07/23, 09:37

  18. Benjamin Franzke voted on patch set 5 V +2 CR +2 11/07/23, 09:38

  19. Benjamin Franzke merged patch set 6 11/07/23, 09:38