Review main Merged Breaking

80819[!!!][TASK] Remove jQuery from `@typo3/backend/document-save-actions` module

Andreas Kienast CR +2 V +2 Hard +163 −100 updated 09/20/23, 15:55

Commit message

The JavaScript module `@typo3/backend/document-save-actions` is used in
FormEngine and Scheduler context mainly to disable the submit button in
the according forms, where also a spinner is rendered within the button
to visualize a running action.

Over the time, the module took over some tasks that logically belong to
FormEngine, which lead to slimming down the module. In a further effort,
jQuery has been removed from said module, leading to a change in
behavior how the callback chain can be aborted.

Native JavaScript events cannot get asked whether event propagation has
been stopped, making changes in the callbacks necessary. All callbacks
registered via `addPreSubmitCallback()` now need to return a boolean
value.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 2131

Show 6 earlier messages
  1. Andreas Kienast uploaded patch set 1 09/01/23, 14:08

  2. Andreas Kienast updated the commit message in patch set 2 09/01/23, 14:09

  3. Christian Kuhn commented on patch set 2 09/01/23, 14:10

    wrong issue number?
  4. Andreas Kienast commented on patch set 2 CR -1 09/01/23, 14:13

    Reply

    god damn it, thanks!
  5. Andreas Kienast uploaded patch set 3 CR -1 09/01/23, 14:14

  6. Andreas Kienast commented on patch set 3 09/01/23, 14:14

    Reply

    Done
  1. core-ci voted on patch set 1 V -1 09/01/23, 14:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46142

  2. core-ci voted on patch set 2 V -1 09/01/23, 14:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46143

  3. core-ci voted on patch set 3 V -1 09/01/23, 14:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46144

  4. Andreas Kienast uploaded patch set 4 V -1 09/01/23, 14:49

  5. core-ci voted on patch set 4 V -1 09/01/23, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46147

  6. Andreas Kienast uploaded patch set 5 V -1 09/04/23, 10:10

  7. core-ci voted on patch set 5 V +1 09/04/23, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46187

  8. Andreas Kienast updated the commit message in patch set 6 V +1 09/05/23, 06:15

  9. core-ci voted on patch set 6 V +1 09/05/23, 06:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46210

  10. Andreas Kienast uploaded patch set 7 V +1 09/07/23, 10:10

  11. core-ci voted on patch set 7 V +1 09/07/23, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46340

  12. Benjamin Franzke commented on patch set 7 09/12/23, 12:19

    scheduler.ts:43

    Hm, I don't get this callback. We actually don't need it at all in here, right? If I'm not totally wrong, then zero callbacks is like all callbacks returning true. So we actually only need `DocumentSaveActions.getInstance()`?
  13. Andreas Kienast commented on patch set 7 09/12/23, 12:28

    scheduler.ts:43 Reply

    Technically yes.
  14. Benjamin Franzke uploaded patch set 8 V +1 09/12/23, 12:55

  15. Benjamin Franzke commented on patch set 8 09/12/23, 12:55

    scheduler.ts:43 Reply

    Done
  16. core-ci voted on patch set 8 V +1 09/12/23, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46519

  17. Andreas Kienast uploaded patch set 9 CR +1 V +1 09/13/23, 13:55

  18. core-ci voted on patch set 9 V +1 09/13/23, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46550

  19. Benjamin Franzke voted on patch set 9 V +1 CR +1 09/13/23, 14:04

  20. Andreas Kienast uploaded patch set 10 CR +1 V +1 09/19/23, 09:17

  21. core-ci voted on patch set 10 V +1 09/19/23, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46745

  22. Benjamin Franzke voted on patch set 10 V +1 CR +1 09/19/23, 12:18

  23. Stefan Bürk voted on patch set 10 V +1 CR +1 09/20/23, 15:42

  24. Andreas Kienast voted on patch set 10 V +2 CR +2 09/20/23, 15:55

  25. Andreas Kienast merged patch set 11 09/20/23, 15:55