80819[!!!][TASK] Remove jQuery from `@typo3/backend/document-save-actions` module
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Stefan Bürk +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 9
- Build/Sources/TypeScript/backend/document-save-actions.ts+83 −58
- Build/Sources/TypeScript/backend/form-engine-validation.ts+20 −18
- Build/Sources/TypeScript/backend/form-engine.ts+6 −17
- Build/Sources/TypeScript/scheduler/scheduler.ts3+1 −3
- typo3/sysext/backend/Resources/Public/JavaScript/document-save-actions.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+1 −1
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-101822-ChangeCallbackInterruptionInTypo3backenddocument-save-actions.rstnew+49 −0
- typo3/sysext/scheduler/Resources/Public/JavaScript/scheduler.js+1 −1
Review log 2131
Show 6 earlier messages
-
Andreas Kienast uploaded patch set 1 09/01/23, 14:08
-
Andreas Kienast updated the commit message in patch set 2 09/01/23, 14:09
-
Christian Kuhn commented on patch set 2 09/01/23, 14:10
wrong issue number? -
Andreas Kienast commented on patch set 2 CR -1 09/01/23, 14:13
Reply
god damn it, thanks! -
Andreas Kienast uploaded patch set 3
CR -109/01/23, 14:14 -
Andreas Kienast commented on patch set 3 09/01/23, 14:14
Reply
Done
-
core-ci voted on patch set 1 V -1 09/01/23, 14:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46142
-
core-ci voted on patch set 2 V -1 09/01/23, 14:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46143
-
core-ci voted on patch set 3 V -1 09/01/23, 14:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46144
-
Andreas Kienast uploaded patch set 4
V -109/01/23, 14:49 -
core-ci voted on patch set 4 V -1 09/01/23, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46147
-
Andreas Kienast uploaded patch set 5
V -109/04/23, 10:10 -
core-ci voted on patch set 5 V +1 09/04/23, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46187
-
Andreas Kienast updated the commit message in patch set 6
V +109/05/23, 06:15 -
core-ci voted on patch set 6 V +1 09/05/23, 06:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46210
-
Andreas Kienast uploaded patch set 7
V +109/07/23, 10:10 -
core-ci voted on patch set 7 V +1 09/07/23, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46340
-
Benjamin Franzke commented on patch set 7 09/12/23, 12:19
scheduler.ts:43Hm, I don't get this callback. We actually don't need it at all in here, right? If I'm not totally wrong, then zero callbacks is like all callbacks returning true. So we actually only need `DocumentSaveActions.getInstance()`? -
Andreas Kienast commented on patch set 7 09/12/23, 12:28
scheduler.ts:43ReplyTechnically yes. -
Benjamin Franzke uploaded patch set 8
V +109/12/23, 12:55 -
Benjamin Franzke commented on patch set 8 09/12/23, 12:55
scheduler.ts:43ReplyDone -
core-ci voted on patch set 8 V +1 09/12/23, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46519
-
Andreas Kienast uploaded patch set 9
CR +1V +109/13/23, 13:55 -
core-ci voted on patch set 9 V +1 09/13/23, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46550
-
Benjamin Franzke voted on patch set 9 V +1 CR +1 09/13/23, 14:04
-
Andreas Kienast uploaded patch set 10
CR +1V +109/19/23, 09:17 -
core-ci voted on patch set 10 V +1 09/19/23, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46745
-
Benjamin Franzke voted on patch set 10 V +1 CR +1 09/19/23, 12:18
-
Stefan Bürk voted on patch set 10 V +1 CR +1 09/20/23, 15:42
-
Andreas Kienast voted on patch set 10 V +2 CR +2 09/20/23, 15:55
-
Andreas Kienast merged patch set 11 09/20/23, 15:55