Review 12.4 Merged

80830[TASK] Migrate helper entry point scripts to TypeScript

Benjamin Franzke CR +2 V +2 Hard +448 −358 updated 09/04/23, 12:36

Commit message

Now that our build chain targets ESM modules, we can
use our TypeScript toolchain to also build utility
entry point scripts, allowing to make use of TypeScript
checking and centralize asset management.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 25

Show 5 more files

Review log 68

  1. Benjamin Franzke uploaded patch set 1 09/04/23, 09:30

  2. Benjamin Franzke commented on patch set 1 CR -1 09/04/23, 09:32

    typo3/sysext/core/Resources/Public/JavaScript/requirejs-loader.js should be migrated as well (not present in `main`)
  3. core-ci voted on patch set 1 V +1 09/04/23, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46186

  4. Benjamin Franzke uploaded patch set 2 CR -1 V +1 09/04/23, 12:18

    git mv requirejs-loader
  5. Benjamin Franzke uploaded patch set 3 09/04/23, 12:19

    Define requirejs-loader types
  6. Benjamin Franzke voted on patch set 3 V +2 CR +2 09/04/23, 12:22

  7. core-ci voted on patch set 3 V +1 09/04/23, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46190

  8. Benjamin Franzke merged patch set 4 09/04/23, 12:36