Review 12.4 Merged

80846[TASK] Simplify markup of collapse buttons

Benjamin Kott CR +2 V +2 Easy +9 −14 updated 09/06/23, 10:05

Commit message

We are removing the obsolete .collapseIcon
wrapper and replace the icons directly.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 57

  1. Benjamin Kott commented on patch set 1 09/06/23, 09:22

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php * typo3/sysext/scheduler/Resources/Public/JavaScript/scheduler.js
  2. core-ci voted on patch set 1 V -1 09/06/23, 09:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46279

  3. Benjamin Kott uploaded patch set 2 V -1 09/06/23, 09:40

  4. Benjamin Kott commented on patch set 2 09/06/23, 09:40

    This change is ready for review.
  5. core-ci voted on patch set 2 V +1 09/06/23, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46280

  6. Benjamin Kott voted on patch set 2 V +2 CR +2 09/06/23, 10:04

  7. Benjamin Kott merged patch set 3 09/06/23, 10:05