Review 12.4 Merged

80852[TASK] Migrate @typo3/t3editor/stream-parser/typoscript to TypeScript

Benjamin Franzke CR +2 V +2 Nightmare +1628 −1762 updated 09/05/23, 14:08

Commit message

The parser originates from the original codemirror javascript-mode
and therefore contains a lot of legacy and unneeded code.
Code that is obviously unneded for TypoScript (like
backticks (called "quasi") or function expressions are removed
to reduce the amount of code that needs to be type-declared.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 5

Review log 56

  1. Benjamin Franzke uploaded patch set 1 09/04/23, 12:40

  2. Benjamin Franzke marked it work in progress 09/04/23, 12:40

  3. core-ci voted on patch set 1 V +1 09/04/23, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46191

  4. Benjamin Franzke marked it ready for review 09/05/23, 14:08

  5. Benjamin Franzke voted on patch set 1 V +2 CR +2 09/05/23, 14:08

  6. Benjamin Franzke merged patch set 2 09/05/23, 14:08