Review main Merged

80858[FEATURE] Allow configuration of color palettes in FormEngine

Andreas Kienast CR +2 V +2 Normal +106 −10 updated 09/19/23, 07:49

Commit message

TYPO3 uses a color picker component that already supports color
palettes, or swatches. Integrators are now able to configure such color
palettes for use in FormEngine via PageTS.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 2126

Show 1 earlier messages
  1. Andreas Kienast uploaded patch set 1 09/05/23, 06:48

  1. Andreas Kienast uploaded patch set 2 09/05/23, 06:49

  2. core-ci voted on patch set 1 V +1 09/05/23, 06:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46212

  3. core-ci voted on patch set 2 V +1 09/05/23, 06:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46213

  4. Christian Kuhn commented on patch set 2 09/05/23, 20:33

    could we showcase with a Styleguide example?
  5. Andreas Kienast commented on patch set 2 09/06/23, 05:14

    Reply

    Sure. Put the following PageTS on the "elements basic" page or somewhere else in the rootline: ``` TCEFORM.tx_styleguide_elements_basic.color_1.colorPalette = #ff8700, #0080c9, #515151, #dd123d TCEFORM.tx_styleguide_elements_basic.colorPalette = #000000, #ffffff ``` When you edit a record of type "Form engine elements - input, text, checkbox, radio, none, passthrough, user", the color pickers of the fields "color_1" and "color_2" have swatches now.
  6. Benjamin Franzke commented on patch set 2 CR -1 09/06/23, 05:54

    color-picker.ts:41

    It is a pity alwan does not support labels for the swatches. (It doesn't even apply accessible labels to the swatch-buttons :\ ) I'd love to have a) labels b) prepare our config to be able to define a label per color (sure, it probably doesn't make sense right now, if we can not output such labels – maybe we can get that added to alwan?)

    ColorElement.php:245

    Hm, I think we should rather use `;` as separator, as `,` might be used in color values like: ``` hsl(59,76,51) ```
  7. Benjamin Franzke uploaded patch set 3 CR -1 V +1 09/06/23, 06:01

  8. Benjamin Franzke commented on patch set 3 09/06/23, 06:01

    ColorElement.php:245 Reply

    Done
  9. core-ci voted on patch set 3 V +1 09/06/23, 06:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46264

  10. Andreas Kienast commented on patch set 3 09/06/23, 06:19

    ColorElement.php:245 Reply

    That won't help with TCA type=color as it enforces #HEX anyway.
  11. Andreas Kienast commented on patch set 3 CR -1 09/06/23, 06:47

    Still not sure about the config
  12. Andreas Kienast uploaded patch set 4 CR -1 V +1 09/06/23, 08:54

  13. Stefan Bürk commented on patch set 3 09/06/23, 08:54

    Not as a blocker - but would it make sense to add a example to styleguide after this patch is merged ? Just asking.
  14. Andreas Kienast commented on patch set 4 09/06/23, 09:02

    Reply

    That's what lolli already requested. Yes, it makes IMO sense.
  15. core-ci voted on patch set 4 V -1 09/06/23, 09:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46275

  16. Andreas Kienast uploaded patch set 5 V -1 09/06/23, 09:11

  17. core-ci voted on patch set 5 V +1 09/06/23, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46276

  18. Andreas Kienast commented on patch set 5 09/06/23, 09:21

    color-picker.ts:41 Reply

  19. Stefan Bürk commented on patch set 5 09/06/23, 09:22

    Reply

    Sry, overread lollis comment. Thanks for answering ;)
  20. Benjamin Franzke voted on patch set 5 V +1 CR +1 09/12/23, 13:37

  21. Andreas Nedbal voted on patch set 5 V +1 CR +1 09/14/23, 12:43

  22. Andreas Kienast voted on patch set 5 V +2 CR +2 09/14/23, 12:52

  23. Andreas Kienast merged patch set 6 09/14/23, 12:52

  24. Christian Kuhn commented on patch set 6 09/18/23, 10:40

    Reply

    would you like to prepare a patch for styleguide?
  25. Andreas Kienast commented on patch set 6 09/19/23, 07:49

    Reply

    I'd love to but fail to understand the general structure how the generator works and where I'd put the PageTS at best.