Review main Merged

80862[BUGFIX] Toggle checkmark when switching aspect ratio

Andreas Kienast CR +2 V +2 Easy +5 −0 updated 09/05/23, 11:45

Commit message

The image cropper component uses buttons to let a backend user toggle
the currently active aspect ratio setting, indicated via an `active`
class and a checkmark icon. With the removal of Font Awesome in #97877,
some CSS was removed that was responsible for toggling the visibility of
the checkmark icons.

This patch adds the missing CSS again, including necessary adaptions to
Core's Icon API.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Andreas Kienast uploaded patch set 1 09/05/23, 08:15

  2. core-ci voted on patch set 1 V +1 09/05/23, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46219

  3. Garvin Hicking commented on patch set 1 V +1 CR +1 09/05/23, 08:45

    Tested on my installation, works!
  4. Stefan Bürk voted on patch set 1 V +1 CR +1 09/05/23, 10:47

  5. Andreas Kienast voted on patch set 1 V +2 CR +2 09/05/23, 11:34

  6. Andreas Kienast merged patch set 2 09/05/23, 11:45