Review main Merged

80872[BUGFIX] Ensure online media without author works

Benni Mack CR +2 V +2 Easy +27 −23 updated 09/08/23, 09:22

Commit message

When an oembed provider does not send
an "author_name" property, then the request fails,
and there is a sys_file without a sys_file_metadata.

This then results that the show info popup does not work.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Johannes Schlier +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Johannes Schlier +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1317

  1. Benni Mack uploaded patch set 1 09/05/23, 15:51

  2. Benni Mack updated the commit message in patch set 2 09/05/23, 15:51

  3. core-ci voted on patch set 2 V +1 09/05/23, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46249

  4. core-ci voted on patch set 1 V +1 09/05/23, 16:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46248

  5. Stefan Bürk commented on patch set 2 09/05/23, 16:45

    Guess little typo here, but a funny one. Guess should be "media"
  6. Benni Mack updated the commit message in patch set 3 V +1 09/05/23, 16:59

  7. core-ci voted on patch set 3 V +1 09/05/23, 17:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46252

  8. Johannes Schlier commented on patch set 3 V +1 CR +1 09/06/23, 12:34

    Looks good and works as intended in a project where this problem cropped up.
  9. Johannes Schlier commented on patch set 3 09/06/23, 12:39

    Found a small error in the commit message.
    Should be `an "author_name"` To be pedantic about English grammar.
  10. Benni Mack updated the commit message in patch set 4 CR +1 V +1 09/07/23, 22:45

  11. Benni Mack commented on patch set 4 09/07/23, 22:45

    Reply

    Done

    Reply

    Done
  12. core-ci voted on patch set 4 V +1 09/07/23, 22:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46365

  13. Oliver Klee voted on patch set 4 CR +1 09/08/23, 06:43

  14. Johannes Schlier voted on patch set 4 V +1 CR +1 09/08/23, 07:26

  15. Benjamin Franzke voted on patch set 4 CR +1 09/08/23, 08:44

  16. Benjamin Franzke voted on patch set 4 V +2 CR +2 09/08/23, 08:52

  17. Benjamin Franzke merged patch set 5 09/08/23, 09:22