Review 12.4 Merged

80921[TASK] Clean up usages of ContentObjectRenderer request attribute

Stefan Bürk CR +2 V +2 Easy +12 −15 updated 09/07/23, 21:07

Commit message

ContentObjectRenderer is now added as request attribute in
certain cases. But since the signature of obtaining an attribute
from a request correctly states, that the attribute can be null,
consuming code should account for that and defensively
fall back to defaults, when the object can not be obtained.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Stefan Bürk uploaded patch set 1 09/07/23, 20:54

  2. core-ci voted on patch set 1 V +1 09/07/23, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46360

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 09/07/23, 21:07

  4. Stefan Bürk merged patch set 2 09/07/23, 21:07