Review main Merged

80930[TASK] Remove unwanted `use function` php import

Stefan Bürk CR +2 V +2 Easy +2 −4 updated 09/08/23, 22:22

Commit message

Using function imports with `use` is usually not used
in the TYPO3 core. Due to an oversight in the review
for #92768 this slipped in.

This change uses the `self::assertCount()` instead of
the import function `assertCount()` to follow current
policy again.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Stefan Bürk uploaded patch set 1 09/08/23, 21:59

  2. Stefan Bürk commented on patch set 1 09/08/23, 22:00

    Note for reviewers: Related patch has been also backported to 11.5, but the fixes in this change have been directly applied on the backport for v11. This align this for main and 12.4 now.
  3. Benni Mack voted on patch set 1 V +1 CR +1 09/08/23, 22:04

  4. core-ci voted on patch set 1 V +1 09/08/23, 22:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46404

  5. Stefan Bürk commented on patch set 1 09/08/23, 22:13

    Will merge this as only testing related when backport is green.
  6. Stefan Bürk voted on patch set 1 V +2 CR +2 09/08/23, 22:22

  7. Stefan Bürk merged patch set 2 09/08/23, 22:22