Review main Merged

80935[TASK] Apply php-cs-fixer across all php files

Stefan Bürk CR +2 V +2 Normal +102 −102 updated 09/10/23, 05:41

Commit message

php-cs-fixer rules have been changed and only
partially applied yet, also with the recently
merged php-cs-fixer raise and mitigation of a
deprecated rule in #101888. That patch should
have used the `-s cgl` instead of `-s cglGit`
which only scans within php files included in
the very same commit - not applying it across
all files.

This change mitigates this by executing the
php-cs-fixer against all files.

Used command(s):

> Build/Scripts/runTests.sh -s cgl

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Wand +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Wand +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 62

Show 42 more files

Review log 1115

  1. Stefan Bürk uploaded patch set 1 09/09/23, 15:40

  2. Stefan Bürk commented on patch set 1 CR -1 09/09/23, 15:41

    running nightly on it ...
  3. core-ci voted on patch set 1 V +1 09/09/23, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46427

  4. core-ci voted on patch set 1 V -1 09/09/23, 16:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46428

  5. Oliver Wand voted on patch set 1 CR +1 09/09/23, 16:08

  6. core-ci voted on patch set 1 V +1 09/09/23, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46428

  7. Stefan Bürk commented on patch set 1 09/09/23, 16:24

    keep -1 until pre-patch have completed backport chain.
  8. Oliver Wand voted on patch set 1 V +1 09/09/23, 16:26

  9. Stefan Bürk updated the commit message in patch set 2 CR +1 V +1 09/09/23, 17:12

  10. core-ci voted on patch set 2 V +1 09/09/23, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46431

  11. Anja Leichsenring voted on patch set 2 V +1 CR +1 09/09/23, 17:24

  12. Oliver Wand voted on patch set 2 V +1 CR +1 09/09/23, 17:25

  13. Stefan Bürk voted on patch set 2 V +2 CR +2 09/09/23, 17:28

  14. Stefan Bürk merged patch set 3 09/09/23, 17:28

  15. Simon Schaufelberger commented on patch set 3 09/10/23, 05:41

    Unresolved

    should this not also be backported at least to v12?