Review main Merged

80938[FEATURE] Auto-create DB fields from TCA columns for type "folder"

Anja Leichsenring CR +2 V +2 Normal +63 −5 updated 09/11/23, 16:54

Commit message

Tables with TCA columns set to type="folder" do not
need an ext_tables.sql entry anymore. The core now
creates this field automatically.

This is one patch of more in this area: The v13 goal
is to obsolete ext_tables.sql in most cases by
creating default "business" fields of TCA tables
automatically.

The patch adds the main magic in class DefaultTcaSchema
and removes own ext_tables.sql definitions having
type="folder".

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 2130

Show 35 earlier messages
  1. Anja Leichsenring uploaded patch set 1 09/10/23, 08:47

  2. core-ci voted on patch set 1 V +1 09/10/23, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46437

  3. Oliver Klee commented on patch set 2 V +1 09/10/23, 10:16

    Published edit on patch set 1.
  4. Oliver Klee voted on patch set 2 V +1 CR +1 09/10/23, 10:17

  5. core-ci voted on patch set 2 V +1 09/10/23, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46438

  1. Oliver Wand voted on patch set 2 CR +1 09/10/23, 10:48

  2. Stefan Bürk commented on patch set 2 CR -1 09/10/23, 11:33

    on it ...
  3. Anja Leichsenring uploaded patch set 3 CR +1 V +1 09/11/23, 04:56

  4. core-ci voted on patch set 3 V +1 09/11/23, 05:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46451

  5. Andreas Kienast commented on patch set 3 09/11/23, 06:01

    Feature-101553-Auto-createDBFieldsFromTCAColumns.rst:3

    please keep this timestamp, that was explicitly requested by the docs team some time ago
  6. Anja Leichsenring commented on patch set 3 09/11/23, 06:09

    Feature-101553-Auto-createDBFieldsFromTCAColumns.rst:3 Reply

    and I thought it was a mistake. What is this timestamp? The whole request evaded me.
  7. Andreas Kienast commented on patch set 3 09/11/23, 06:12

    Feature-101553-Auto-createDBFieldsFromTCAColumns.rst:3 Reply

    It's the timestamp generated by the ReST helper when creating the document. It acts as a "label".
  8. Andreas Kienast commented on patch set 3 09/11/23, 06:14

    Feature-101553-Auto-createDBFieldsFromTCAColumns.rst:3 Reply

  9. Anja Leichsenring commented on patch set 4 V +1 09/11/23, 06:17

    Published edit on patch set 3.
  10. Anja Leichsenring commented on patch set 4 09/11/23, 06:18

    Feature-101553-Auto-createDBFieldsFromTCAColumns.rst:3 Reply

    Done
  11. Anja Leichsenring commented on patch set 5 09/11/23, 06:19

    Published edit on patch set 4.
  12. core-ci voted on patch set 4 V +1 09/11/23, 06:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46452

  13. core-ci voted on patch set 5 V +1 09/11/23, 06:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46453

  14. Georg Ringer commented on patch set 5 09/11/23, 06:38

    I guess more a feature?
  15. core-ci voted on patch set 5 V -1 09/11/23, 13:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46481

  16. core-ci voted on patch set 5 V +1 09/11/23, 16:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46481

  17. Stefan Bürk uploaded patch set 6 V +1 09/11/23, 16:17

  18. Stefan Bürk commented on patch set 6 09/11/23, 16:19

    Reply

    Done
  19. core-ci voted on patch set 6 V -1 09/11/23, 16:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46484

  20. Stefan Bürk uploaded patch set 7 V -1 09/11/23, 16:28

  21. Stefan Bürk uploaded patch set 8 09/11/23, 16:30

  22. Nikita Hovratov voted on patch set 8 V +1 CR +1 09/11/23, 16:33

  23. core-ci voted on patch set 8 V +1 09/11/23, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46486

  24. Stefan Bürk voted on patch set 8 V +2 CR +2 09/11/23, 16:54

  25. Stefan Bürk merged patch set 9 09/11/23, 16:54