Review main Merged

80942[BUGFIX] Redefine database field review_state of ExtensionManager

Anja Leichsenring CR +2 V +2 Easy +2 −2 updated 09/11/23, 07:02

Commit message

The field was defined as type='check', which gets autogenerated
since #101653 as a positive int value. The field however contains
values in the negative range, rendering it unfit to be represented
as a checkbox field.
Redefining the field as a numeric input field and restoring the
sql definiton avoids the possible data loss and handling errors.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Thomas Hohn +1
    • Oliver Wand +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 67

  1. Anja Leichsenring uploaded patch set 1 09/11/23, 04:53

  2. Thomas Hohn voted on patch set 1 CR +1 09/11/23, 04:56

  3. core-ci voted on patch set 1 V +1 09/11/23, 05:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46449

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 09/11/23, 05:18

  5. Oliver Wand voted on patch set 1 CR +1 09/11/23, 05:32

  6. Benjamin Franzke voted on patch set 1 V +2 CR +2 09/11/23, 07:02

  7. Benjamin Franzke merged patch set 2 09/11/23, 07:02