Review 12.4 Merged

80952[TASK] Stop using getAccessibleMockForAbstractClass in EXT:core

Benjamin Franzke CR +2 V +2 Hard +279 −5 updated 09/11/23, 08:11

Commit message

`getMockForAbstractClass` has been (soft-)deprecated in PHPUnit 10.1:
https://github.com/sebastianbergmann/phpunit/issues/5241

Hence, we should replace its usages to follow best practices and
avoid deprecation warnings later with PHPUnit 11.

We do this by creating dedicated fixture subclasses of the affected
abstract classes.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 58

  1. Benjamin Franzke commented on patch set 1 09/11/23, 07:19

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 V +2 CR +2 09/11/23, 07:30

  3. core-ci voted on patch set 1 V -1 09/11/23, 07:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46458

  4. Benjamin Franzke uploaded patch set 2 CR +2 V +2 09/11/23, 07:47

  5. core-ci voted on patch set 2 V -1 09/11/23, 07:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46460

  6. Benjamin Franzke uploaded patch set 3 CR +2 V +2 09/11/23, 07:57

  7. core-ci voted on patch set 3 V +1 09/11/23, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46462

  8. Benjamin Franzke merged patch set 4 09/11/23, 08:11