Review main Merged

80990[FEATURE] Auto DB fields from TCA for type "group"

Anja Leichsenring CR +2 V +2 Normal +94 −35 updated 09/20/23, 08:42

Commit message

Tables with TCA columns set to type="group" do not
need an ext_tables.sql entry anymore. The core now
creates this field automatically.

This is one of many patches in this area: The v13 goal
is to obsolete ext_tables.sql in most cases by
creating default "business" fields of TCA tables
automatically.

The patch adds the main magic in class DefaultTcaSchema
and removes own ext_tables.sql definitions having
type=group.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 14

Review log 2033

Show 48 earlier messages
  1. Anja Leichsenring uploaded patch set 1 09/13/23, 10:19

  2. Anja Leichsenring uploaded patch set 2 09/13/23, 10:19

  3. core-ci voted on patch set 1 V -1 09/13/23, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46536

  4. core-ci voted on patch set 2 V -1 09/13/23, 10:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46537

  5. Anja Leichsenring uploaded patch set 3 V -1 09/13/23, 11:32

  6. core-ci voted on patch set 3 V -1 09/13/23, 11:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46542

  7. Anja Leichsenring uploaded patch set 4 V -1 09/13/23, 11:56

  8. core-ci voted on patch set 4 V +1 09/13/23, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46543

  1. Nikita Hovratov uploaded patch set 5 V +1 09/18/23, 12:52

  2. Nikita Hovratov commented on patch set 5 09/18/23, 12:58

    DefaultTcaSchema.php:643

    I'm not sure, if we should do the maxitems/allowedTablesCount logic. While this is fine for the Core, which will unlikely see changes in these options, users probably will change maxitems/allowed more often. This could lead to incompatible SQL column changes. I suggest to keep MM => integer, but drop the other part and override it in ext_tables.sql. BTW, this screams that type=group should probably be further split up into different TCA types. At least one dedicated type for MM relations.
  3. core-ci voted on patch set 5 V +1 09/18/23, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46665

  4. Anja Leichsenring uploaded patch set 6 V +1 09/19/23, 17:12

  5. Anja Leichsenring commented on patch set 5 09/19/23, 17:13

    DefaultTcaSchema.php:643 Reply

    Ack
  6. core-ci voted on patch set 6 V -1 09/19/23, 17:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46805

  7. Anja Leichsenring uploaded patch set 7 V -1 09/19/23, 17:48

  8. core-ci voted on patch set 7 V -1 09/19/23, 17:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46813

  9. Anja Leichsenring uploaded patch set 8 V -1 09/19/23, 18:18

  10. core-ci voted on patch set 8 V -1 09/19/23, 18:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46821

  11. Anja Leichsenring uploaded patch set 9 V -1 09/19/23, 18:30

  12. Anja Leichsenring uploaded patch set 10 09/19/23, 18:33

  13. Anja Leichsenring uploaded patch set 11 09/19/23, 18:39

  14. core-ci voted on patch set 9 V -1 09/19/23, 18:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46822

  15. core-ci voted on patch set 10 V -1 09/19/23, 18:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46823

  16. Anja Leichsenring uploaded patch set 12 09/19/23, 18:46

  17. core-ci voted on patch set 11 V -1 09/19/23, 18:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46824

  18. core-ci voted on patch set 12 V +1 09/19/23, 18:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46825

  19. Georg Ringer commented on patch set 12 09/19/23, 19:58

    pages-and-ttcontent-with-image.xml:211

    wanna adapt the spaces?
  20. Nikita Hovratov uploaded patch set 13 V +1 09/20/23, 07:10

  21. Nikita Hovratov commented on patch set 13 09/20/23, 07:11

    pages-and-ttcontent-with-image.xml:211 Reply

    Done
  22. core-ci voted on patch set 13 V +1 09/20/23, 07:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46845

  23. Nikita Hovratov voted on patch set 13 V +1 CR +1 09/20/23, 07:21

  24. Georg Ringer voted on patch set 13 V +2 CR +2 09/20/23, 08:42

  25. Georg Ringer merged patch set 14 09/20/23, 08:42