Review 11.5 Merged

80999[BUGFIX] Prevent type error in TypoLinkViewHelper

Benni Mack CR +2 V +2 Easy +1 −1 updated 09/14/23, 09:42

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Benni Mack commented on patch set 1 09/14/23, 07:47

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/14/23, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46566

  3. Susi Moog voted on patch set 1 V +1 CR +1 09/14/23, 07:56

  4. Stefan Bürk commented on patch set 1 09/14/23, 07:58

    12.4 missing here ?
  5. Benni Mack commented on patch set 1 09/14/23, 08:02

    Reply

    nope. this was a PHP 8 error, which was not merged in 11.5, but in "main" (which was before we branched 12.4)
  6. Stefan Bürk commented on patch set 1 V +1 CR +1 09/14/23, 08:04

    Reply

    Ack. Thanks for answering.
  7. Benjamin Franzke voted on patch set 1 V +1 CR +1 09/14/23, 08:07

  8. Benjamin Franzke voted on patch set 1 V +2 CR +2 09/14/23, 09:42

  9. Benjamin Franzke merged patch set 2 09/14/23, 09:42