Review main Merged

81017[FEATURE] Auto DB fields from TCA for type "language"

Anja Leichsenring CR +2 V +2 Easy +43 −0 updated 09/19/23, 10:09

Commit message

Tables with TCA columns set to type="language" do not
need an ext_tables.sql entry anymore. The core now
creates this field automatically.

This is one of many patches in this area: The v13 goal
is to obsolete ext_tables.sql in most cases by
creating default "business" fields of TCA tables
automatically.

The patch adds the main magic in class DefaultTcaSchema.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 2029

Show 34 earlier messages
  1. Anja Leichsenring uploaded patch set 1 09/14/23, 04:23

  2. core-ci voted on patch set 1 V +1 09/14/23, 04:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46557

  3. Anja Leichsenring commented on patch set 2 V +1 09/14/23, 10:16

    Published edit on patch set 1.
  4. Anja Leichsenring commented on patch set 3 09/14/23, 10:16

    Published edit on patch set 2.
  1. core-ci voted on patch set 3 V +1 09/14/23, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46571

  2. core-ci voted on patch set 2 V -1 09/14/23, 10:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46570

  3. Stefan Bürk voted on patch set 3 V +1 CR +1 09/18/23, 06:15

  4. Oli Bartsch commented on patch set 3 CR -1 09/18/23, 09:06

    DefaultTcaSchema.php:634

    Does are no file field(s).
  5. Anja Leichsenring commented on patch set 4 CR +1 V +1 09/18/23, 16:20

    Published edit on patch set 3.
  6. Anja Leichsenring commented on patch set 4 09/18/23, 16:21

    DefaultTcaSchema.php:634 Reply

    Done
  7. Anja Leichsenring rebased onto patch set 5 09/18/23, 16:21

  8. core-ci voted on patch set 4 V +1 09/18/23, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46685

  9. core-ci voted on patch set 5 V +1 09/18/23, 16:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46686

  10. Anja Leichsenring uploaded patch set 6 V +1 09/19/23, 03:58

  11. core-ci voted on patch set 6 V +1 09/19/23, 04:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46729

  12. Andreas Kienast voted on patch set 6 V +1 CR +1 09/19/23, 07:59

  13. Stefan Bürk commented on patch set 6 09/19/23, 08:10

  14. Torben Hansen commented on patch set 6 CR -1 09/19/23, 08:16

    DefaultTcaSchema.php:664

    We must use `'unsigned' => true,` here, since the value for "All" is `-1`.
  15. Andreas Kienast commented on patch set 6 09/19/23, 08:18

    DefaultTcaSchema.php:664 Reply

    If we make the field unsigned, we cannot have negative numbers.
  16. Torben Hansen commented on patch set 6 V +1 CR +1 09/19/23, 08:23

    DefaultTcaSchema.php:664 Reply

    Sorry, my mistake.
  17. Göran Bodenschatz voted on patch set 6 CR +1 09/19/23, 08:35

  18. core-ci voted on patch set 6 V -1 09/19/23, 08:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46737

  19. core-ci voted on patch set 6 V +1 09/19/23, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46737

  20. Christian Kuhn rebased onto patch set 7 CR +1 V +1 09/19/23, 09:57

  21. Christian Kuhn voted on patch set 7 V +1 CR +1 09/19/23, 10:02

  22. Stefan Bürk voted on patch set 7 V +1 CR +1 09/19/23, 10:05

  23. core-ci voted on patch set 7 V +1 09/19/23, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46749

  24. Christian Kuhn voted on patch set 7 V +2 CR +2 09/19/23, 10:09

  25. Christian Kuhn merged patch set 8 09/19/23, 10:09