Review main Merged

81018[TASK] Update to CKEditor5 v39

Benjamin Franzke CR +2 V +2 Nightmare +2564 −1104 updated 09/20/23, 14:13

Commit message

https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-39.html

Executed commands:
  npm install -P $(
    grep ckeditor5 package.json | \
    grep '\^38' | \
    grep -v dev-utils | \
    sed 's/^[^"]*"\([^"]*\)".*/\1@^39/' \
  )
  npm run build

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Nedbal +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Nedbal +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 65

Show 45 more files

Review log 912

  1. Benjamin Franzke uploaded patch set 1 09/14/23, 06:56

  2. core-ci voted on patch set 1 V -1 09/14/23, 07:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46561

  3. Benjamin Franzke uploaded patch set 2 V -1 09/14/23, 07:32

  4. core-ci voted on patch set 2 V +1 09/14/23, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46563

  5. Benjamin Franzke updated the commit message in patch set 3 V +1 09/14/23, 07:41

  6. core-ci voted on patch set 3 V +1 09/14/23, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46565

  7. Benjamin Franzke marked it work in progress 09/14/23, 08:08

  8. Benjamin Franzke marked it ready for review 09/18/23, 08:26

  9. Benni Mack voted on patch set 3 V +1 CR +1 09/18/23, 11:06

  10. Andreas Nedbal voted on patch set 3 V +1 CR +1 09/20/23, 13:28

  11. Benjamin Franzke voted on patch set 3 V +2 CR +2 09/20/23, 13:54

  12. Benjamin Franzke merged patch set 4 09/20/23, 14:13