81019[BUGFIX] Fix CKEditor5 migration for contentsCss with query strings
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 79
-
Benjamin Franzke uploaded patch set 1 09/14/23, 09:34
-
Benjamin Franzke commented on patch set 1 CR -1 09/14/23, 09:44
forgot to add tests -
Benjamin Franzke uploaded patch set 2
CR -109/14/23, 09:47 -
Benjamin Franzke commented on patch set 2 09/14/23, 09:47
Reply
Done -
core-ci voted on patch set 1 V +1 09/14/23, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46567
-
core-ci voted on patch set 2 V +1 09/14/23, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46569
-
Andreas Kienast voted on patch set 2 CR +1 09/14/23, 11:06
-
Garvin Hicking commented on patch set 2 09/15/23, 09:58
Unresolved
Note that currently this is related to https://forge.typo3.org/issues/101911 - asset paths are not properly calculated for a composer-installation inside a subdirectory; a proper fix for this may affect this place here, too. -
Benjamin Franzke abandoned the change 10/02/23, 10:46