Review main Abandoned

81019[BUGFIX] Fix CKEditor5 migration for contentsCss with query strings

Benjamin Franzke CR 0 V 0 Easy +47 −2 updated 10/02/23, 10:46

Commit message

In TYPO3 v11 a query string needed to be appended to RTE contentCss
resource configuration in order to enforce browser cache busting when
the CSS file was changed by an integrator.

Since TYPO3 v12 the resource is preprocessed which means the query
string must be stripped as it will not be found in the filesystem.

The migrator is adapted to automatically remove query strings.
It is expected that manually migrated configurations (those that
already switched to the newer array notation) do not need this
workaround, as they have already been migrated, and needed to
remove the query string anyway.

Still, to prevent a similar PHP warning, a logged warning is
emitted instead of assuming the configured file always exists.
This way invalid filepaths are now explicitly ignored instead
of implicitly (happened because their delegated resource request
failed due to the mentioned query string).

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 79

  1. Benjamin Franzke uploaded patch set 1 09/14/23, 09:34

  2. Benjamin Franzke commented on patch set 1 CR -1 09/14/23, 09:44

    forgot to add tests
  3. Benjamin Franzke uploaded patch set 2 CR -1 09/14/23, 09:47

  4. Benjamin Franzke commented on patch set 2 09/14/23, 09:47

    Reply

    Done
  5. core-ci voted on patch set 1 V +1 09/14/23, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46567

  6. core-ci voted on patch set 2 V +1 09/14/23, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46569

  7. Andreas Kienast voted on patch set 2 CR +1 09/14/23, 11:06

  8. Garvin Hicking commented on patch set 2 09/15/23, 09:58

    Unresolved

    Note that currently this is related to https://forge.typo3.org/issues/101911 - asset paths are not properly calculated for a composer-installation inside a subdirectory; a proper fix for this may affect this place here, too.
  9. Benjamin Franzke abandoned the change 10/02/23, 10:46