Review main Merged

81028[TASK] Migrate t3-overview-list usages

Benjamin Kott CR +2 V +2 Normal +33 −43 updated 09/18/23, 07:26

Commit message

The report overview was adjusted to match other
already existing entrypoints like the about module.
In the form framework the class is simply dropped
as it provided no additional benefit.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 56

  1. Benjamin Kott uploaded patch set 1 09/15/23, 10:41

  2. core-ci voted on patch set 1 V +1 09/15/23, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46605

  3. Benjamin Franzke commented on patch set 1 V +1 CR +1 09/15/23, 12:10

    the reports menu (which links to the report overview) can be manually trigged by changing typo3/sysext/reports/Classes/Controller/ReportController.php menu conditions to: if (count($allReports) > 1 || true) {
  4. Andreas Nedbal voted on patch set 1 V +1 CR +1 09/15/23, 20:47

  5. Benjamin Kott voted on patch set 1 V +2 CR +2 09/18/23, 06:47

  6. Benjamin Kott merged patch set 2 09/18/23, 07:26