81050[TASK] Move GraphicalFunctions code to ImageProcessingInstructions
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 7
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php3+23 −188
- typo3/sysext/core/Classes/Imaging/ImageDimension.php4+22 −23
- typo3/sysext/core/Classes/Imaging/ImageProcessingInstructions.php10new+269 −0
- typo3/sysext/core/Classes/Resource/Processing/LocalCropScaleMaskHelper.php+15 −45
- typo3/sysext/core/Tests/Unit/Imaging/GraphicalFunctionsTest.php+0 −273
- typo3/sysext/core/Tests/Unit/Imaging/ImageProcessingInstructionsTest.php2new+282 −0
Review log 3145
Show 1120 earlier messages
-
Benni Mack uploaded patch set 1 09/18/23, 15:32
-
core-ci voted on patch set 1 V -1 09/18/23, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46684
-
Benni Mack uploaded patch set 2
V -109/18/23, 16:37 -
core-ci voted on patch set 2 V -1 09/18/23, 16:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46688
-
Benni Mack uploaded patch set 3
V -109/18/23, 17:13 -
core-ci voted on patch set 3 V +1 09/18/23, 17:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46693
-
Benni Mack uploaded patch set 4
V +109/19/23, 17:49 -
core-ci voted on patch set 4 V +1 09/19/23, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46814
-
Oliver Klee commented on patch set 4 09/20/23, 11:51
-
Benni Mack uploaded patch set 5
V +109/26/23, 10:33 -
core-ci voted on patch set 5 V -1 09/26/23, 10:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47178
-
Oliver Klee commented on patch set 5 09/26/23, 11:31
ImageDimension.php:32ReplyDone -
Benni Mack uploaded patch set 6
V -109/26/23, 17:37 -
core-ci voted on patch set 6 V -1 09/26/23, 17:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47199
-
Benni Mack uploaded patch set 7
V -110/07/23, 07:35 -
core-ci voted on patch set 7 V -1 10/07/23, 07:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47533
-
Benni Mack uploaded patch set 8
V -110/07/23, 08:36 -
core-ci voted on patch set 8 V +1 10/07/23, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47537
-
Benni Mack uploaded patch set 9
V +110/07/23, 08:51 -
core-ci voted on patch set 9 V +1 10/07/23, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47538
-
Oliver Klee commented on patch set 9 V +1 10/07/23, 09:38
Looks very good in general! Thanks for cleaning this areas of the code up. I’ve added some comments. If the scope of this change is only moving code, but not improving the moved code, please feel free to ignore the corresponding comments.ImageDimension.php:33I propose to add `@param int<o, max>` for both properties to narrow down the range.ImageProcessingInstructions.php:30Many of these properties can get an `@var int<0, max>` annotation to narrow down the range.ImageProcessingInstructions.php:37As is it possible to instantiate this class with `new` (without using a factory method), this property should have an empty string as the default value.ImageProcessingInstructions.php:111Let’s be more specific (as `$width` is an integer, not a boolean): `if ($width > 0) {`ImageProcessingInstructions.php:127Ditto.ImageProcessingInstructions.php:153Ditto in this code block.ImageProcessingInstructionsTest.php:266Please let’s add type annotations for the parameters. -
Benni Mack commented on patch set 9 10/07/23, 09:40
Reply
I'm fine with the changes you proposed - can you take care of them? The code is already covered quite well with tests but I added a few more. That's the goal of this change. -
Oliver Klee commented on patch set 9 10/07/23, 11:47
Reply
Yes, will do. -
Oliver Klee uploaded patch set 10
V +110/07/23, 17:18 -
Oliver Klee commented on patch set 9 V +1 10/07/23, 17:18
ImageDimension.php:33ReplyDoneImageProcessingInstructions.php:30ReplyDoneImageProcessingInstructions.php:37ReplyDoneImageProcessingInstructions.php:111ReplyDoneImageProcessingInstructions.php:127ReplyDoneImageProcessingInstructions.php:153ReplyDoneImageProcessingInstructionsTest.php:266ReplyDone -
Oliver Klee commented on patch set 10 10/07/23, 17:18
Reply
Done -
Oliver Klee voted on patch set 10 V +1 10/07/23, 17:18
-
core-ci voted on patch set 10 V +1 10/07/23, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47541
-
Benni Mack uploaded patch set 11
V +110/07/23, 19:34 -
core-ci voted on patch set 11 V -1 10/07/23, 19:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47544
-
Simon Schaufelberger updated the commit message in patch set 12
V -110/07/23, 20:16 -
Benni Mack rebased onto patch set 13 10/08/23, 19:21
-
core-ci voted on patch set 13 V -1 10/08/23, 19:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47569
-
Benni Mack uploaded patch set 14
V -110/09/23, 12:47 -
core-ci voted on patch set 14 V +1 10/09/23, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47593
-
Oliver Klee voted on patch set 14 V +1 10/09/23, 13:32
-
Oliver Klee commented on patch set 14 10/09/23, 13:34
GraphicalFunctions.php:366Why are we removing the cropscale information from the hash input here? -
Benni Mack uploaded patch set 15
V +110/09/23, 14:06 -
Benni Mack commented on patch set 14 10/09/23, 14:06
GraphicalFunctions.php:366Replymy bad, I forgot to re-add this -
core-ci voted on patch set 15 V +1 10/09/23, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47596
-
Christian Kuhn commented on patch set 15 10/11/23, 08:38
GraphicalFunctions.php:366ReplyDone -
Christian Kuhn voted on patch set 15 V +1 CR +1 10/11/23, 09:12
-
Oliver Klee voted on patch set 15 V +1 10/11/23, 11:06
-
Stefan Bürk voted on patch set 15 V +2 CR +2 10/11/23, 11:32
-
Stefan Bürk merged patch set 16 10/11/23, 11:32
ImageDimension.php:32